Skip to content

Commit b01b098

Browse files
committed
syz-manager: silently update the corpus version
The v4->v5 transition has inadvertetly led to impossibly slow corpus triage attempts on syzkaller instances that use emulated VMs. They never finish the corpus triage, so they never bump the version. Now that the original change has already reached its purpose, let's no longer force the re-smashing of all corpus items.
1 parent 08010a8 commit b01b098

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

syz-manager/manager.go

+7-1
Original file line numberDiff line numberDiff line change
@@ -669,7 +669,13 @@ func (mgr *Manager) preloadCorpus() {
669669
fallthrough
670670
case 4:
671671
// Version 4->5: fix for comparison argument sign extension.
672-
corpusFlags &= ^fuzzer.ProgSmashed
672+
// Introduced in 1ba0279d74a35e96e81de87073212d2b20256e8f.
673+
674+
// Update (July 2024):
675+
// We used to reset the fuzzer.ProgSmashed flag here, but it has led to
676+
// perpetual corpus retriage on slow syzkaller instances. By now, all faster
677+
// instances must have already bumped their corpus versions, so let's just
678+
// increase the version to let all others go past the corpus triage stage.
673679
fallthrough
674680
case currentDBVersion:
675681
}

0 commit comments

Comments
 (0)