Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueryRecordsResponse should not include hint field #367

Closed
yuryu opened this issue Jul 24, 2022 · 0 comments · Fixed by #368
Closed

QueryRecordsResponse should not include hint field #367

yuryu opened this issue Jul 24, 2022 · 0 comments · Fixed by #368

Comments

@yuryu
Copy link
Member

yuryu commented Jul 24, 2022

What happened:
QueryRecordsResponse has a hint field but it should not have been there... Hints are something passed from the client not returned by the server.
It's been around since #123 but never been implemented. I think we should just delete it before 1.0.

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Open Saves version:
  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • Install method (yaml/helm):
  • Troubleshooting guide log(s):
  • Others:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant