Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor]: remove slug segment from DELETE comment API URL endpoint #810

Closed
geromegrignon opened this issue Nov 14, 2021 · 2 comments
Closed

[Refactor]: remove slug segment from DELETE comment API URL endpoint #810

geromegrignon opened this issue Nov 14, 2021 · 2 comments
Labels
Status: RFC awaiting for comments to be approved v2 changelog
Milestone
V2

Comments

@geromegrignon
Copy link
Contributor

Description

The current API URL to delete a comment is /articles/{slug}/comments/{id}.
The slug segment is the slug of the related article.
To delete a comment, this slug isn't required.

Solution

Change the URL to /articles/comments/{id}.
@geromegrignon geromegrignon mentioned this issue Nov 14, 2021
Closed
@geromegrignon geromegrignon added the Status: RFC awaiting for comments to be approved label Nov 15, 2021
@geromegrignon geromegrignon self-assigned this May 22, 2022
@geromegrignon geromegrignon moved this to In Progress in RealWorld V2 May 22, 2022
@geromegrignon geromegrignon added this to the V2 milestone May 22, 2022
@geromegrignon geromegrignon moved this from In Progress to Done in RealWorld V2 May 22, 2022
@geromegrignon geromegrignon removed their assignment Jun 5, 2022
@spiroskmaris
Copy link

can i work on this issue please?

@geromegrignon
Copy link
Contributor Author

discontinued task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: RFC awaiting for comments to be approved v2 changelog
Projects
RealWorld V2
Status: Done
Milestone
V2
Development

No branches or pull requests
2 participants
@geromegrignon @spiroskmaris