Move openvasd_start_scan warning up in case the cJSON err is empty

mattmundell · mattmundell · commit b51923b2f19c · 2025-01-12T13:02:50.000+02:00
diff --git a/openvasd/openvasd.c b/openvasd/openvasd.c
@@ -810,6 +810,7 @@ openvasd_start_scan (openvasd_connector_t conn, gchar *data)
   if (!parser)
     {
       const gchar *error_ptr = cJSON_GetErrorPtr ();
+      g_warning ("%s: Error parsing json string to get the scan ID", __func__);
       if (error_ptr != NULL)
         {
           response->body = g_strdup_printf ("{\"error\": \"%s\"}", error_ptr);
@@ -819,7 +820,6 @@ openvasd_start_scan (openvasd_connector_t conn, gchar *data)
         {
           response->body = g_strdup (
             "{\"error\": \"Parsing json string to get the scan ID\"}");
-          g_warning ("%s: Parsing json string to get the scan ID", __func__);
         }
       response->code = RESP_CODE_ERR;
       cJSON_Delete (parser);

Original file line number	Diff line number	Diff line change
`@@ -810,6 +810,7 @@ openvasd_start_scan (openvasd_connector_t conn, gchar *data)`
`810`	`810`	`if (!parser)`
`811`	`811`	`{`
`812`	`812`	`const gchar *error_ptr = cJSON_GetErrorPtr ();`
	`813`	`+ g_warning ("%s: Error parsing json string to get the scan ID", __func__);`
`813`	`814`	`if (error_ptr != NULL)`
`814`	`815`	`{`
`815`	`816`	`response->body = g_strdup_printf ("{\"error\": \"%s\"}", error_ptr);`
`@@ -819,7 +820,6 @@ openvasd_start_scan (openvasd_connector_t conn, gchar *data)`
`819`	`820`	`{`
`820`	`821`	`response->body = g_strdup (`
`821`	`822`	`"{\"error\": \"Parsing json string to get the scan ID\"}");`
`822`		`- g_warning ("%s: Parsing json string to get the scan ID", __func__);`
`823`	`823`	`}`
`824`	`824`	`response->code = RESP_CODE_ERR;`
`825`	`825`	`cJSON_Delete (parser);`