Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CertifyLegal to demos #146

Closed
funnelfiasco opened this issue Sep 13, 2024 · 3 comments · Fixed by #181
Closed

Add CertifyLegal to demos #146

funnelfiasco opened this issue Sep 13, 2024 · 3 comments · Fixed by #181
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@funnelfiasco
Copy link
Collaborator

Probably in known-and-unknown.md

@funnelfiasco funnelfiasco self-assigned this Sep 13, 2024
@funnelfiasco funnelfiasco added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 13, 2024
@funnelfiasco
Copy link
Collaborator Author

This needs to happen after the next release, which will include the ClearlyDefined certifier in the demo compose file.

@robert-cronin
Copy link
Contributor

I'd like to take this one on if no one else has started already, however I think there is a dependency here that's worth noting:

The guacone query known command is the main way the known-and-unknown.md demo explores different GUAC nodes, but it doesn't yet include CertifyLegal nodes to the best of my knowledge.

To properly document CertifyLegal in the docs, I've submitted a PR here that adds CertifyLegal support to the query known command first.

@funnelfiasco
Copy link
Collaborator Author

Good catch! We should consider whether or not we want a demo of legal to be part of the broader known-and-unknown demo or if we want it standalone. Anecdotally, the legal info seems to be a major feature for some users. On the other hand, we don't have a lot to show at the moment (I'm thinking about what a query legal command might do before I open that feature request), so it's probably fine to put it in there for now.

One thing I want to undertake in the near future is reworking some of the demos to put the vuln-related stuff first (since that seems to have the best retention from our Google Analytics stats), so depending on which of us gets done first, there might be some edits to make anyway. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants