Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Remove SLSA binding to in-toto-golang #2450

Open
pxp928 opened this issue Jan 23, 2025 · 6 comments
Open

[feature] Remove SLSA binding to in-toto-golang #2450

pxp928 opened this issue Jan 23, 2025 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@pxp928
Copy link
Collaborator

pxp928 commented Jan 23, 2025

Is your feature request related to a problem? Please describe.
in-toto-golang is being deprecated. We should move the SLSA parser to use in-toto attestations instead for the SLSA provenance.

remove the bindings: "github.com/in-toto/in-toto-golang/in_toto/slsa_provenance/v0.1" and "github.com/in-toto/in-toto-golang/in_toto/slsa_provenance/v0.2"

GUAC version
main

@pxp928 pxp928 added the enhancement New feature or request label Jan 23, 2025
@pxp928 pxp928 changed the title [feature] FILL THIS IN [feature] Remove SLSA binding to in-toto-golang Jan 23, 2025
@kpauljoseph
Copy link

Shall I take this up?

@pxp928
Copy link
Collaborator Author

pxp928 commented Jan 24, 2025

Thanks @kpauljoseph, I will assign you the issue!

@kpauljoseph
Copy link

@pxp928
How do we handle the provenance v0.1 and v0.2 requirement in slsa parser?
Noe, the in-toto/attestation has a v0 model which is based on https://slsa.dev/spec/v0.2/provenance

There's a considerable difference between both these versions as well.

@pxp928
Copy link
Collaborator Author

pxp928 commented Feb 11, 2025

@kpauljoseph Not sure if I understand your question but the SLSA Parser: https://github.com/guacsec/guac/blob/main/pkg/ingestor/parser/slsa/parser_slsa.go uses in-toto-golang for v0.1 and v0.2 SLSA provenance.

	slsa01 "github.com/in-toto/in-toto-golang/in_toto/slsa_provenance/v0.1"
	slsa02 "github.com/in-toto/in-toto-golang/in_toto/slsa_provenance/v0.2"

@kpauljoseph
Copy link

kpauljoseph commented Feb 16, 2025

@pxp928 yes, based on the conversation here: the v0.2 model was ported over as v0 in in-toto/attestation. Should we separate that to v0.1 and v0.2 like we'd done in the beginning?

@pxp928
Copy link
Collaborator Author

pxp928 commented Feb 18, 2025

Yes, as want backwards compatibility where possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants