Skip to content

Commit 96f18f5

Browse files
committed
accounts/abi: fix some go-critic linter warnings (ethereum#23709)
1 parent 189e7d5 commit 96f18f5

File tree

1 file changed

+10
-15
lines changed

1 file changed

+10
-15
lines changed

accounts/abi/reflect.go

+10-15
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,13 @@ import (
2828
// given type
2929
// e.g. turn
3030
// var fields []reflect.StructField
31-
// fields = append(fields, reflect.StructField{
32-
// Name: "X",
33-
// Type: reflect.TypeOf(new(big.Int)),
34-
// Tag: reflect.StructTag("json:\"" + "x" + "\""),
35-
// }
31+
//
32+
// fields = append(fields, reflect.StructField{
33+
// Name: "X",
34+
// Type: reflect.TypeOf(new(big.Int)),
35+
// Tag: reflect.StructTag("json:\"" + "x" + "\""),
36+
// }
37+
//
3638
// into
3739
// type TupleT struct { X *big.Int }
3840
func ConvertType(in interface{}, proto interface{}) interface{} {
@@ -123,22 +125,15 @@ func set(dst, src reflect.Value) error {
123125
func setSlice(dst, src reflect.Value) error {
124126
slice := reflect.MakeSlice(dst.Type(), src.Len(), src.Len())
125127
for i := 0; i < src.Len(); i++ {
126-
if src.Index(i).Kind() == reflect.Struct {
127-
if err := set(slice.Index(i), src.Index(i)); err != nil {
128-
return err
129-
}
130-
} else {
131-
// e.g. [][32]uint8 to []common.Hash
132-
if err := set(slice.Index(i), src.Index(i)); err != nil {
133-
return err
134-
}
128+
if err := set(slice.Index(i), src.Index(i)); err != nil {
129+
return err
135130
}
136131
}
137132
if dst.CanSet() {
138133
dst.Set(slice)
139134
return nil
140135
}
141-
return errors.New("Cannot set slice, destination not settable")
136+
return errors.New("cannot set slice, destination not settable")
142137
}
143138

144139
func setArray(dst, src reflect.Value) error {

0 commit comments

Comments
 (0)