accounts/usbwallet: simplify code using -= operator (ethereum#17904)

gzliudan · gzliudan · commit b2e6accb23bb · 2025-01-23T15:44:24.000+08:00
diff --git a/accounts/usbwallet/ledger.go b/accounts/usbwallet/ledger.go
@@ -351,7 +351,7 @@ func (w *ledgerDriver) ledgerSign(derivationPath []uint32, tx *types.Transaction
 		signer = new(types.HomesteadSigner)
 	} else {
 		signer = types.NewEIP155Signer(chainID)
-		signature[crypto.RecoveryIDOffset] = signature[crypto.RecoveryIDOffset] - byte(chainID.Uint64()*2+35)
+		signature[crypto.RecoveryIDOffset] -= byte(chainID.Uint64()*2+35)
 	}
 	signed, err := tx.WithSignature(signer, signature)
 	if err != nil {
diff --git a/accounts/usbwallet/trezor.go b/accounts/usbwallet/trezor.go
@@ -223,7 +223,7 @@ func (w *trezorDriver) trezorSign(derivationPath []uint32, tx *types.Transaction
 	} else {
 		// Trezor backend does not support typed transactions yet.
 		signer = types.NewEIP155Signer(chainID)
-		signature[crypto.RecoveryIDOffset] = signature[crypto.RecoveryIDOffset] - byte(chainID.Uint64()*2+35)
+		signature[crypto.RecoveryIDOffset] -= byte(chainID.Uint64()*2+35)
 	}
 
 	// Inject the final signature into the transaction and sanity check the sender

Original file line number	Diff line number	Diff line change
`@@ -351,7 +351,7 @@ func (w ledgerDriver) ledgerSign(derivationPath []uint32, tx types.Transaction`
`351`	`351`	`signer = new(types.HomesteadSigner)`
`352`	`352`	`} else {`
`353`	`353`	`signer = types.NewEIP155Signer(chainID)`
`354`		`- signature[crypto.RecoveryIDOffset] = signature[crypto.RecoveryIDOffset] - byte(chainID.Uint64()*2+35)`
	`354`	`+ signature[crypto.RecoveryIDOffset] -= byte(chainID.Uint64()*2+35)`
`355`	`355`	`}`
`356`	`356`	`signed, err := tx.WithSignature(signer, signature)`
`357`	`357`	`if err != nil {`
Original file line number	Diff line number	Diff line change
`@@ -223,7 +223,7 @@ func (w trezorDriver) trezorSign(derivationPath []uint32, tx types.Transaction`
`223`	`223`	`} else {`
`224`	`224`	`// Trezor backend does not support typed transactions yet.`
`225`	`225`	`signer = types.NewEIP155Signer(chainID)`
`226`		`- signature[crypto.RecoveryIDOffset] = signature[crypto.RecoveryIDOffset] - byte(chainID.Uint64()*2+35)`
	`226`	`+ signature[crypto.RecoveryIDOffset] -= byte(chainID.Uint64()*2+35)`
`227`	`227`	`}`
`228`	`228`
`229`	`229`	`// Inject the final signature into the transaction and sanity check the sender`