Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

take over jp2k image handling #10

Open
jcupitt opened this issue Mar 5, 2024 · 2 comments
Open

take over jp2k image handling #10

jcupitt opened this issue Mar 5, 2024 · 2 comments

Comments

@jcupitt
Copy link
Collaborator

jcupitt commented Mar 5, 2024

We could make the kakadu loader take over all jpeg2000 image handling for libvips, though this would probably break some stuff.

@jcupitt jcupitt mentioned this issue Mar 5, 2024
@scossu
Copy link
Collaborator

scossu commented Mar 5, 2024

What are the risks? This is a nice to have, but if there is a risk of breakage (especially in edge cases that we may not catch right away) I could do away with it.

What is the default behavior of other modules (e.g. OPJ)?

@jcupitt
Copy link
Collaborator Author

jcupitt commented Mar 5, 2024

The APIs for kakaduload and save don't exactly match the built-in libvips jp2k load and save, so you can't just swap them. It shouldn't crash, but you could get "arg not known" messages, or find settings unexpectedly had no effect.

It's probably not a very serious worry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants