Skip to content

Commit 8bcdf2a

Browse files
committed
Merge #117: cmake: Remove legacy MSVC build system
8d3bb2b cmake: Remove legacy MSVC build system (Hennadii Stepanov) 00b3061 cmake, docs: Update MSVC build docs (Hennadii Stepanov) 1c8ce0f fixup! cmake: Add preset for MSVC build (Hennadii Stepanov) Pull request description: At this stage, the new CMake-based build system offers a comprehensive set of features, surpassing those of the legacy build system located in the `build_msvc` directory. As part of the transition to the new build system, the legacy MSVC build system has been removed. Additionally, a new ["Windows / MSVC Build Guide"](https://github.com/hebasto/bitcoin/blob/240309-cmake-BX/doc/build-windows-msvc.md) has been introduced, based on https://gist.github.com/hebasto/32c77c0cd592d13685437271ac6b79f6. Notably, the guide lacks information regarding the disabling of base address randomization (see bitcoin#21045). Even with `-DHARDENING=OFF`, this feature remains enabled by default. ACKs for top commit: m3dwards: ACK 8d3bb2b Tree-SHA512: f53f11f5193d579308299e4cadb736f15eb3a3c0d7edebb54f5c2bbc231cbdc7b1f21cfc7c6fc7e9eff39e956077344b641844ab80030ce680566a9c8c9e3726
2 parents 43b0aa5 + 8d3bb2b commit 8bcdf2a

38 files changed

+90
-1880
lines changed

CMakePresets.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"configurePresets": [
55
{
66
"name": "vs2022",
7-
"displayName": "Build using 'Visual Studio 17 2022' generator",
7+
"displayName": "Build using 'Visual Studio 17 2022' generator and 'x64-windows' triplet",
88
"condition": {
99
"type": "equals",
1010
"lhs": "${hostSystemName}",
@@ -20,7 +20,7 @@
2020
},
2121
{
2222
"name": "vs2022-static",
23-
"displayName": "Build using 'Visual Studio 17 2022' generator",
23+
"displayName": "Build using 'Visual Studio 17 2022' generator and 'x64-windows-static' triplet",
2424
"condition": {
2525
"type": "equals",
2626
"lhs": "${hostSystemName}",

build_msvc/.gitignore

-30
This file was deleted.

build_msvc/README.md

-92
This file was deleted.

build_msvc/bench_bitcoin/bench_bitcoin.vcxproj.in

-62
This file was deleted.

build_msvc/bitcoin-cli/bitcoin-cli.vcxproj

-34
This file was deleted.

build_msvc/bitcoin-qt/bitcoin-qt.vcxproj

-84
This file was deleted.

build_msvc/bitcoin-tx/bitcoin-tx.vcxproj

-37
This file was deleted.

0 commit comments

Comments
 (0)