cmake [KILL 3-STATE]: Switch MULTIPROCESS to boolean w/ default OFF

Author: hebasto

CMakeLists.txt

@@ -107,7 +107,12 @@ tristate_option(WITH_EXTERNAL_SIGNER
   AUTO
 )
 tristate_option(WITH_QRENCODE "Enable QR code support." "if libqrencode is found." AUTO)
-tristate_option(MULTIPROCESS "Build multiprocess bitcoin-node, bitcoin-wallet, and bitcoin-gui executables in addition to monolithic bitcoind and bitcoin-qt executables. Requires libmultiprocess library. Experimental." "if libmultiprocess is found." OFF)
+
+option(MULTIPROCESS "Build multiprocess bitcoin-node, bitcoin-wallet, and bitcoin-gui executables in addition to monolithic bitcoind and bitcoin-qt executables. Requires libmultiprocess library. Experimental." OFF)
+if(MULTIPROCESS)
+  find_package(Libmultiprocess CONFIG REQUIRED)
+  find_package(LibmultiprocessGen CONFIG REQUIRED)
+endif()
 
 option(BUILD_TESTS "Build test_bitcoin executable." ON)
 cmake_dependent_option(BUILD_GUI_TESTS "Build test_bitcoin-qt executable." ON "BUILD_TESTS" OFF)

cmake/optional.cmake

@@ -154,15 +154,3 @@ if(WITH_GUI AND WITH_QRENCODE)
     message(FATAL_ERROR "libqrencode requested, but not found.")
   endif()
 endif()
-
-if(MULTIPROCESS)
-  find_package(Libmultiprocess CONFIG)
-  find_package(LibmultiprocessGen CONFIG)
-  if(TARGET Libmultiprocess::multiprocess AND TARGET Libmultiprocess::mpgen)
-    set(MULTIPROCESS ON)
-  elseif(MULTIPROCESS STREQUAL "AUTO")
-    set(MULTIPROCESS OFF)
-  else()
-    message(FATAL_ERROR "\"-DMULTIPROCESS=ON\" specified, but libmultiprocess library was not found.")
-  endif()
-endif()

depends/toolchain.cmake.in

@@ -163,10 +163,8 @@ else()
 endif()
 
 if("@multiprocess@" STREQUAL "1")
-  if(NOT MULTIPROCESS)
-    set(MULTIPROCESS ON CACHE STRING "")
-  endif()
-  if(NOT LibmultiprocessGen_DIR)
-    set(LibmultiprocessGen_DIR "${CMAKE_FIND_ROOT_PATH}/native/lib/cmake/LibmultiprocessGen" CACHE PATH "")
-  endif()
+  set(MULTIPROCESS ON CACHE BOOL "")
+  set(LibmultiprocessGen_DIR "${CMAKE_FIND_ROOT_PATH}/native/lib/cmake/LibmultiprocessGen" CACHE PATH "")
+else()
+  set(MULTIPROCESS OFF CACHE BOOL "")
 endif()