Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Allow overriding/take into account user flags #279

Closed
hebasto opened this issue Jul 23, 2024 · 2 comments · Fixed by #282
Closed

cmake: Allow overriding/take into account user flags #279

hebasto opened this issue Jul 23, 2024 · 2 comments · Fixed by #282
Labels
bug Something isn't working

Comments

@hebasto
Copy link
Owner

hebasto commented Jul 23, 2024

# Check for ARMv8 SHA-NI intrinsics.
set(ARM_SHANI_CXXFLAGS -march=armv8-a+crypto)

Looks like these don't allow overriding/take into account user flags? i.e If I configure with -DCMAKE_CXX_FLAGS_RELEASE="-march=armv8-a+nocrypto", I'd expect the ARM SHA-NI check to fail, but it doesn't. Also doesn't seem to work with APPEND_CXXFLAGS, which should always be (globally) taken into account?

Originally posted in bitcoin#30454 (comment).

@fanquake
Copy link

What is the status of this? Otherwise we are reintroducing issues like bitcoin#28864, and generally, just shouldn't be ignoring user provided flags.

@hebasto
Copy link
Owner Author

hebasto commented Jul 25, 2024

What is the status of this? Otherwise we are reintroducing issues like bitcoin#28864, and generally, just shouldn't be ignoring user provided flags.

See #282.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants