Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review use of docker buildx in CI #539

Closed
jdolitsky opened this issue Jan 30, 2022 · 5 comments
Closed

Review use of docker buildx in CI #539

jdolitsky opened this issue Jan 30, 2022 · 5 comments

Comments

@jdolitsky
Copy link
Contributor

The current build takes over 1 hour. Perhaps at the very least the buildx build and push steps can combined?

@cbuto
Copy link
Contributor

cbuto commented Feb 4, 2022

@jdolitsky 👀 I was taking a peek at this and planning on putting up a PR with a proposal at some point. I think if we build all the chartmuseum binaries (make cross-build) and copy them into the images (depending on the TARGETARCH), we can speed up the docker builds (which seem to take a lot of time due to having to download the go modules each time).

@scbizu
Copy link
Contributor

scbizu commented Feb 4, 2022

@cbuto It seems already existed in Makefile which called make-cross ? We only need to fix our action to use the build-cross and remove the go build in docker build (which no module cache per platform build) and adjust the docker mv command 🤔

@cbuto
Copy link
Contributor

cbuto commented Feb 4, 2022

@scbizu yup! that's exactly what I was thinking, I have a branch that is close to working just trying to test it locally 🚀

@cbuto
Copy link
Contributor

cbuto commented Feb 4, 2022

The last build took 27m 5s! I tested a few different architectures and everything appears to be working as expected 🎉

@jdolitsky
Copy link
Contributor Author

phenomenal. Great work @cbuto. think we shall close this for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants