-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review use of docker buildx in CI #539
Comments
@jdolitsky 👀 I was taking a peek at this and planning on putting up a PR with a proposal at some point. I think if we build all the chartmuseum binaries ( |
@cbuto It seems already existed in Makefile which called make-cross ? We only need to fix our action to use the build-cross and remove the go build in docker build (which no module cache per platform build) and adjust the docker mv command 🤔 |
@scbizu yup! that's exactly what I was thinking, I have a branch that is close to working just trying to test it locally 🚀 |
The last build took |
phenomenal. Great work @cbuto. think we shall close this for now |
The current build takes over 1 hour. Perhaps at the very least the buildx build and push steps can combined?
The text was updated successfully, but these errors were encountered: