Crashing if you set cpu speed to 1000

[vsub]

Don't know who will actually set it to 1000 but it crashes if you hit ok while 1000 is selected
Also if you manually set it to 1000,when you try to enter Game Settings=>System ppsspp will crash

[hrydgard]

Hmm that's really bad.

Yeah, will have to do a 0.9.1 sooner than I expected...

[thedax]

Call stack of the crash(it's the same crash for both ways of triggering it):

>   PPSSPPWindows.exe!UIContext::GetScissorBounds() Line 82 C++
    PPSSPPWindows.exe!UI::ViewGroup::Draw(UIContext & dc) Line 103  C++
    PPSSPPWindows.exe!UI::ScrollView::Draw(UIContext & dc) Line 600 C++
    PPSSPPWindows.exe!UI::ViewGroup::Draw(UIContext & dc) Line 99   C++
    PPSSPPWindows.exe!UI::ViewGroup::Draw(UIContext & dc) Line 99   C++
    PPSSPPWindows.exe!UIScreen::render() Line 37    C++
    PPSSPPWindows.exe!ScreenManager::render() Line 86   C++
    PPSSPPWindows.exe!NativeRender() Line 565   C++
    PPSSPPWindows.exe!Core_RunLoop() Line 137   C++
    PPSSPPWindows.exe!Core_Run() Line 180   C++
    PPSSPPWindows.exe!TheThread(void * __formal) Line 135   C++

[thedax]

Additional info: "Run-Time Check Failure #2 - Stack around the variable 'temp' was corrupted."

[vsub]

It seems to be newui related

[thedax]

Yes, I know.

[unknownbrackets]

I'm sure the bug is here:

void PopupSliderChoice::Draw(UIContext &dc) {
    Choice::Draw(dc);
    char temp[4];
    sprintf(temp, "%i", *value_);
    dc.Draw()->DrawText(dc.theme->uiFont, temp, bounds_.x2() - 12, bounds_.centerY(), 0xFFFFFFFF, ALIGN_RIGHT | ALIGN_VCENTER);
}

4 just isn't very long.

-[Unknown]

[thedax]

Aha, that would explain it. Perhaps 32 would be more reasonable to allow room for growth?

[unknownbrackets]

An unsigned 32-bit integer can be 10 characters long, so that'd be 11. But sure, 32 should be a nice reasonable safe value.

-[Unknown]

[thedax]

Thanks for spotting that, @unknownbrackets.

[thedax]

I think this can be closed now.