Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.3 support #357

Closed
hugovk opened this issue Nov 6, 2017 · 6 comments
Closed

Drop Python 3.3 support #357

hugovk opened this issue Nov 6, 2017 · 6 comments

Comments

@hugovk
Copy link
Contributor

hugovk commented Nov 6, 2017

Is there any interest in dropping support for EOL Python 3.3?

Here's the pip installs from PyPI for the last month, showing low demand for 3.3:

$ pypinfo --percent --pip html5lib pyversion
python_version percent download_count
-------------- ------- --------------
2.7              56.0%        622,860
3.5              19.3%        214,942
3.6              15.6%        172,974
3.4               8.9%         98,411
3.3               0.1%            789
3.7               0.1%            699
2.6               0.1%            681
3.2               0.0%             19
None              0.0%             13
@willkg willkg added this to the 1.0 milestone Nov 7, 2017
@willkg
Copy link
Contributor

willkg commented Nov 7, 2017

Thank you for writing this up with all the relevant links and information--that helps a ton! I'm game for dropping support for Python 3.3. I'll add it to the 1.0 milestone.

If someone has a compelling reason not to drop Python 3.3, please add a comment.

@gsnedders
Copy link
Member

If someone has a compelling reason not to drop Python 3.3, please add a comment.

Historically the viewpoint I've taken is given we're vendored into pip we should support the same set of versions as pip does (to avoid any need for pip to fork html5lib).

@willkg
Copy link
Contributor

willkg commented Nov 7, 2017

Wow--I had no idea html5lib-python was vendored in pip. That's... interesting.

@gsnedders How do we figure out what versions of pip are supported? Are we just checking their current release to see what versions of Python it supports? For example, master tip still supports Python 3.3:

https://github.com/pypa/pip/blob/3998df351853c68274802502fead7607c8ab8eeb/setup.py#L54

@willkg willkg removed this from the 1.0 milestone Nov 7, 2017
@hugovk
Copy link
Contributor Author

hugovk commented Nov 7, 2017

I think it makes sense for pip to vendor things, it needs to be able to install from a download with maybe no external net access except an internal PyPI server.

Here's the pip decision and PR to deprecate 3.3 in the next pip 10 and drop it in pip 11.
pypa/pip#3796
pypa/pip#4355

Their latest stable docs say 2.6, 2.7, 3.3-3.5, pypy.
https://pip.pypa.io/en/stable/installing/#python-and-os-compatibility

Latest master says 2.7, 3.3-3.6, pypy.
https://github.com/pypa/pip/blob/master/docs/installing.rst#python-and-os-compatibility

@gsnedders
Copy link
Member

@willkg mostly @dstufft pinging me (or me him) when they drop stuff :)

@willkg
Copy link
Contributor

willkg commented Nov 7, 2017

That makes sense!

Seems like we shouldn't drop support for 3.3 in html5lib-python 1.0. Beyond that, I'll leave this until you get pinged and we can drop it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants