Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please make TLS support optional #219

Closed
joshtriplett opened this issue Aug 31, 2020 · 5 comments · Fixed by #323
Closed

Please make TLS support optional #219

joshtriplett opened this issue Aug 31, 2020 · 5 comments · Fixed by #323

Comments

@joshtriplett
Copy link
Member

Sometimes, I only need http support, not https; for instance, the instance metadata services in cloud environments only need http. For such cases, I would like to be able to use surf with the async-h1 backend and no TLS stack.

@brightly-salty
Copy link
Contributor

I'd like to take a swing at this and submit a PR if it would be accepted.

@Fishrock123
Copy link
Member

Needs support in http-client. We should support this.

@Fishrock123
Copy link
Member

@brightly-salty are you still interested in this?

I think that the h1_client in http-client already supports running without tls, but surf's feature flags do not.

@brightly-salty
Copy link
Contributor

Sure @Fishrock123 , sorry about that, must've slipped my mind. I'd be happy to work on it, I think it's just making a feature flag and configuring the tls-using code based on that?

@Fishrock123
Copy link
Member

I think it would mostly need to be an alternate feature flag on Surf, probably something like h1-client-no-tls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants