Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend ReflectionDisassembler to support custom attributes on GenericParameterConstraint #1631

Closed
siegfriedpammer opened this issue Aug 10, 2019 · 2 comments
Labels
Decompiler The decompiler engine itself IL Issues about IL view New Feature

Comments

@siegfriedpammer
Copy link
Member

siegfriedpammer commented Aug 10, 2019

See https://github.com/dotnet/coreclr/issues/25488
See also dotnet/roslyn#29997

Once this is finalized/specified update our disassembler to emit the correct syntax.

Note: SRM already supports reading custom attributes for generic constraints. No need to update any dependency. The only issue is that ECMA-335 currently does not specify how custom attributes on type parameter constraints are to be represented in IL.

@siegfriedpammer siegfriedpammer added New Feature Decompiler The decompiler engine itself IL Issues about IL view labels Aug 10, 2019
@siegfriedpammer
Copy link
Member Author

152aa2a implements this, however we should wait and check the official syntax once it is released.

@siegfriedpammer
Copy link
Member Author

Looks like this can be closed, because dotnet/coreclr#25488 is fixed. I verified that the example provided there produces the same IL output in ILSpy.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Decompiler The decompiler engine itself IL Issues about IL view New Feature
Projects
None yet
Development

No branches or pull requests

1 participant