Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft Store package does not contain addins #2490

Closed
christophwille opened this issue Aug 26, 2021 · 4 comments
Closed

Microsoft Store package does not contain addins #2490

christophwille opened this issue Aug 26, 2021 · 4 comments
Labels

Comments

@christophwille
Copy link
Member

r2r and baml decompiler are missing. (vs addin project copies everything, wapproj only has ilspy.csproj reference)

@christophwille
Copy link
Member Author

A solution to this problem also ties in with #2324 (comment)

@christophwille
Copy link
Member Author

christophwille commented Aug 26, 2021

Consideration should be that the Store changes soon https://developer.microsoft.com/en-us/microsoft-store/desktop-apps/ and maybe going with a plain msi would be best (eg using https://github.com/wixtoolset/ - quick overview here https://www.ryadel.com/en/asp-net-create-msi-setup-exe-installer-project-wix-core-winforms-wpf-xaml/)

Alternatives

https://marketplace.visualstudio.com/items?itemName=VisualStudioClient.MicrosoftVisualStudio2017InstallerProjects (useable in gh actions, see actions/runner-images#1382)

https://github.com/oleg-shilo/wixsharp instead of writing XML for WiX Toolset

@christophwille
Copy link
Member Author

Some advantages:

  • Getting rid of the separate solution with UWP dependencies
  • Multi-TFM would be possible out of the gate

@christophwille
Copy link
Member Author

The plan after merging #2558 - keep the wapproj around for 7.2 release cycle, then remove the sln/wapproj/action and only use the MSI installer going forward for Store.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant