Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More themes? #2904

Closed
ltrzesniewski opened this issue Feb 20, 2023 · 1 comment · Fixed by #2906
Closed

More themes? #2904

ltrzesniewski opened this issue Feb 20, 2023 · 1 comment · Fixed by #2906
Labels
Enhancement Areas for improvement

Comments

@ltrzesniewski
Copy link
Contributor

Would you agree to have more theme options?

Is your feature request related to a problem? Please describe.

To be honest, I don't like the yellow background. But more generally, I'd like to have a highlighting theme which is closer to what I use in the IDE.

Describe the solution you'd like

I'd like to replace the light/dark button in the toolbar with a setting that would provide more theme choices. Those could build upon the existing light/dark themes, and would mainly provide new colors for AvalonEdit highlighting. I think the light/dark colors could be kept as-is for the UI.

Currently, the contents of the xshd files is duplicated because of the two themes. I'm thinking about separating the rulesets from the color definitions in order to have one file per language, plus one file per theme, and override the colors in the xshd file when a theme is chosen.

Another option would be to provide a fully customizable color settings screen, but I'm not sure if it's worth the effort.

Additional context

I can work on this, I just wanted to ask if that's a feature you'd accept before I start.

@ltrzesniewski ltrzesniewski added the Enhancement Areas for improvement label Feb 20, 2023
@ltrzesniewski ltrzesniewski mentioned this issue Feb 20, 2023
1 task
@ltrzesniewski
Copy link
Contributor Author

Actually I started implementing this in #2906. Feedback is welcome.

Now I need to actually add some more themes. 🙂

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Areas for improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant