Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

social_icon如果设置为false的话name也不显示了 #772

Closed
2 of 6 tasks
chitanda opened this issue Mar 31, 2016 · 2 comments
Closed
2 of 6 tasks

social_icon如果设置为false的话name也不显示了 #772

chitanda opened this issue Mar 31, 2016 · 2 comments

Comments

@chitanda
Copy link
Contributor

Expected behavior (预期行为)

image

Actual behavior (实际行为)

image

Steps to reproduce the behavior (重现步骤)

NexT Version, NexT Scheme

NexT Version:

  • Master
  • Latest Release
  • Old version -

NexT Scheme:

  • Muse
  • Mist
  • Pisces

Other Information (Like Browser, System, Screenshots)

看了下是sidebar.swig的代码逻辑有点小问题。71行开始的代码:

        <div class="links-of-author motion-element">
          {% if theme.social %}
            {% for name, link in theme.social %}
              <span class="links-of-author-item">
                <a href="{{ link }}" target="_blank">
                  {% if theme.social_icons.enable %}
                    <i class="fa fa-{{ theme.social_icons[name] || 'globe' }}"></i> {{ name }}
                  {% endif %}
                </a>
              </span>
            {% endfor %}
          {% endif %}
        </div>

一旦false了,name也就没了。所以将name移出if判断即可。
已提交PR

@chitanda
Copy link
Contributor Author

我看之前有人提到过这个bug:
#525

@iissnan
Copy link
Owner

iissnan commented Mar 31, 2016

已 Merge,谢谢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants