Skip to content

Commit d7c8373

Browse files
imker25imker25
authored
fix: Update download-artifact action from v3 to v4, Issue #139 (MR #140)
* Update download-artifact action from v3 to v4 Issue #139
1 parent c63b0e4 commit d7c8373

File tree

2 files changed

+26
-26
lines changed

2 files changed

+26
-26
lines changed

‎.github/workflows/ci-jobs.yml

+18-18
Original file line numberDiff line numberDiff line change
@@ -34,25 +34,25 @@ jobs:
3434
- name: 'Get Package name and version from logs/ to GITHUB_ENVIRONMENT'
3535
run: ./build/GithubEnv.sh
3636
- name: 'Upload Artifact samba_exporter'
37-
uses: actions/upload-artifact@v3
37+
uses: actions/upload-artifact@v4
3838
with:
3939
name: samba_exporter-${{ matrix.os }}
4040
path: bin/samba_exporter
4141
retention-days: 1
4242
- name: 'Upload Artifact samba_statusd'
43-
uses: actions/upload-artifact@v3
43+
uses: actions/upload-artifact@v4
4444
with:
4545
name: samba_statusd-${{ matrix.os }}
4646
path: bin/samba_statusd
4747
retention-days: 1
4848
- name: 'Upload Artifact PackageName.txt'
49-
uses: actions/upload-artifact@v3
49+
uses: actions/upload-artifact@v4
5050
with:
5151
name: PackageName-${{ matrix.os }}.txt
5252
path: logs/PackageName.txt
5353
retention-days: 1
5454
- name: 'Upload Artifact ShortVersion.txt'
55-
uses: actions/upload-artifact@v3
55+
uses: actions/upload-artifact@v4
5656
with:
5757
name: ShortVersion-${{ matrix.os }}.txt
5858
path: logs/ShortVersion.txt
@@ -74,7 +74,7 @@ jobs:
7474
depends: ${{ env.SAMBA_EXPORTER_PACKAGE_DEPENDS }}
7575
desc: ${{ env.SAMBA_EXPORTER_PACKAGE_DESCRIPTION }}
7676
- name: "Upload Artifact samba_exporter*.deb"
77-
uses: actions/upload-artifact@v3
77+
uses: actions/upload-artifact@v4
7878
with:
7979
name: samba_exporter-${{ matrix.os }}.deb
8080
path: ${{ env.SAMBA_EXPORTER_PACKAGE_NAME }}_amd64.deb
@@ -92,7 +92,7 @@ jobs:
9292
requirements: 'build/pages/requirements.txt'
9393
configfile: 'build/pages/mkdocs.yml'
9494
- name: "Upload Artifact docs pages"
95-
uses: actions/upload-artifact@v3
95+
uses: actions/upload-artifact@v4
9696
with:
9797
name: docs-pages
9898
path: build/pages/site/**
@@ -110,20 +110,20 @@ jobs:
110110
./build/CreateRpmPackage.sh
111111
build/GithubEnv.sh
112112
- name: "Upload Artifact - RPM"
113-
uses: actions/upload-artifact@v3
113+
uses: actions/upload-artifact@v4
114114
with:
115115
name: samba_exporter-rpm
116116
path: bin/samba-exporter-${{ env.SAMBA_EXPORTER_RPM_VERSION }}-1.x86_64.rpm
117117
retention-days: 1
118118
- name: "Upload Artifact - Docker build log"
119-
uses: actions/upload-artifact@v3
119+
uses: actions/upload-artifact@v4
120120
if: always()
121121
with:
122122
name: docker-build-fedora-log
123123
path: logs/docker-build-fedora.log
124124
retention-days: 1
125125
- name: "Upload Artifact - Unit Test log"
126-
uses: actions/upload-artifact@v3
126+
uses: actions/upload-artifact@v4
127127
if: always()
128128
with:
129129
name: unit-test-fedora-log
@@ -139,12 +139,12 @@ jobs:
139139
steps:
140140
- uses: actions/checkout@v3
141141
- name: Download samba_exporter artifact
142-
uses: actions/download-artifact@v3
142+
uses: actions/download-artifact@v4
143143
with:
144144
name: samba_exporter-${{ matrix.os }}
145145
path: bin/samba_exporter
146146
- name: Download samba_statusd artifact
147-
uses: actions/download-artifact@v3
147+
uses: actions/download-artifact@v4
148148
with:
149149
name: samba_statusd-${{ matrix.os }}
150150
path: bin/samba_statusd
@@ -164,12 +164,12 @@ jobs:
164164
steps:
165165
- uses: actions/checkout@v3
166166
- name: Download samba_exporter artifact
167-
uses: actions/download-artifact@v3
167+
uses: actions/download-artifact@v4
168168
with:
169169
name: samba_exporter-${{ matrix.os }}
170170
path: bin/samba_exporter
171171
- name: Download samba_statusd artifact
172-
uses: actions/download-artifact@v3
172+
uses: actions/download-artifact@v4
173173
with:
174174
name: samba_statusd-${{ matrix.os }}
175175
path: bin/samba_statusd
@@ -189,12 +189,12 @@ jobs:
189189
# steps:
190190
# - uses: actions/checkout@v3
191191
# - name: Download PackageName.txt artifact
192-
# uses: actions/download-artifact@v3
192+
# uses: actions/download-artifact@v4
193193
# with:
194194
# name: PackageName-${{ matrix.os }}.txt
195195
# path: logs/
196196
# - name: Download samba_exporter package artifact
197-
# uses: actions/download-artifact@v3
197+
# uses: actions/download-artifact@v4
198198
# with:
199199
# name: samba_exporter-${{ matrix.os }}.deb
200200
# path: .
@@ -212,17 +212,17 @@ jobs:
212212
steps:
213213
- uses: actions/checkout@v3
214214
- name: Download samba_exporter package artifact
215-
uses: actions/download-artifact@v3
215+
uses: actions/download-artifact@v4
216216
with:
217217
name: samba_exporter-ubuntu-22.04.deb
218218
path: .
219219
- name: Download PackageName.txt artifact
220-
uses: actions/download-artifact@v3
220+
uses: actions/download-artifact@v4
221221
with:
222222
name: PackageName-ubuntu-22.04.txt
223223
path: logs/ubuntu-22.04/
224224
- name: Download ShortVersion.txt artifact
225-
uses: actions/download-artifact@v3
225+
uses: actions/download-artifact@v4
226226
with:
227227
name: ShortVersion-ubuntu-22.04.txt
228228
path: logs/

‎.github/workflows/release-jobs.yml

+8-8
Original file line numberDiff line numberDiff line change
@@ -42,19 +42,19 @@ jobs:
4242
build/PublishLaunchpadInDocker.sh $TAG
4343
fi
4444
- name: 'Upload debian packages artifact'
45-
uses: actions/upload-artifact@v3
45+
uses: actions/upload-artifact@v4
4646
with:
4747
name: samba-exporter_deb-packages
4848
path: bin/deb-packages/binary/*.deb
4949
retention-days: 1
5050
- name: 'Upload man pages artifact'
51-
uses: actions/upload-artifact@v3
51+
uses: actions/upload-artifact@v4
5252
with:
5353
name: samba-exporter_man-pages
5454
path: bin/deb-packages/man/*.*
5555
retention-days: 1
5656
- name: 'Upload docker build logs artifact'
57-
uses: actions/upload-artifact@v3
57+
uses: actions/upload-artifact@v4
5858
if: always()
5959
with:
6060
name: samba-exporter_docker-build-logs
@@ -160,13 +160,13 @@ jobs:
160160
build/PublishRpmInDocker.sh $TAG
161161
fi
162162
- name: 'Upload rpm packages artifact'
163-
uses: actions/upload-artifact@v3
163+
uses: actions/upload-artifact@v4
164164
with:
165165
name: samba-exporter_rpm-packages
166166
path: bin/rpm-packages/**/*.rpm
167167
retention-days: 1
168168
- name: 'Upload docker build logs artifact'
169-
uses: actions/upload-artifact@v3
169+
uses: actions/upload-artifact@v4
170170
if: always()
171171
with:
172172
name: samba-exporter_docker-build-logs
@@ -263,17 +263,17 @@ jobs:
263263
echo "Publish pages"
264264
fi
265265
- name: Download samba_exporter deb-package artifact
266-
uses: actions/download-artifact@v3
266+
uses: actions/download-artifact@v4
267267
with:
268268
name: samba-exporter_deb-packages
269269
path: ./bin/deb-packages/binary/
270270
- name: Download samba_exporter rpm-package artifact
271-
uses: actions/download-artifact@v3
271+
uses: actions/download-artifact@v4
272272
with:
273273
name: samba-exporter_rpm-packages
274274
path: ./bin/rpm-packages/
275275
- name: Download samba_exporter man-pages artifact
276-
uses: actions/download-artifact@v3
276+
uses: actions/download-artifact@v4
277277
with:
278278
name: samba-exporter_man-pages
279279
path: ./bin/deb-packages/man/

0 commit comments

Comments
 (0)