Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packet timeout, TimeoutOnClose, Acknowledgement handlers NOOP functionality missing #392

Closed
plafer opened this issue Feb 1, 2023 · 1 comment
Closed

Packet timeout, TimeoutOnClose, Acknowledgement handlers NOOP functionality missing #392

plafer opened this issue Feb 1, 2023 · 1 comment
Labels
A: bug Admin: something isn't working

Comments

@plafer
Copy link
Contributor

plafer commented Feb 1, 2023 •
edited
Loading

Bug Summary

If 2 relayers submit a MsgTimeout, both transactions should succeed, with the second one being a NOOP, similar to what we do with RecvPacket. Similarly for MsgTimeoutOnClose and MsgAcknowledgement.

Details

See ibc-go.

Version

v0.27.0
@plafer plafer added the A: bug Admin: something isn't working label Feb 1, 2023
@plafer plafer mentioned this issue Feb 1, 2023
Merged
7 tasks
@plafer plafer changed the title Packet timeout handler should NOOP if commitment doesn't exist Packet timeout, TimeoutOnClose, Acknowledgement handlers NOOP functionality missing Feb 1, 2023
@Farhad-Shabani Farhad-Shabani moved this to 📥 To Do in ibc-rs Feb 2, 2023
@Farhad-Shabani Farhad-Shabani added this to the ADR05 milestone Feb 2, 2023
@Farhad-Shabani Farhad-Shabani moved this from 📥 To Do to 🏗️ In Progress in ibc-rs Feb 2, 2023
@Farhad-Shabani Farhad-Shabani modified the milestones: ADR05, Support Anoma's onboarding efforts, Fix known bugs and issues Feb 3, 2023
@plafer
Copy link
Contributor Author

plafer commented Feb 8, 2023

Fixed in #393 for Validation/ExecutionContext API. Let's close this only after #279.

@plafer plafer added the A: blocked Admin: blocked by another (internal/external) issue or PR label Feb 8, 2023
@Farhad-Shabani Farhad-Shabani removed this from the Fix known bugs and issues milestone Feb 8, 2023
@Farhad-Shabani Farhad-Shabani moved this from 🏗️ In Progress to 🛑 Blocked in ibc-rs Feb 8, 2023
@plafer plafer closed this as completed Feb 21, 2023
@github-project-automation github-project-automation bot moved this from 🛑 Blocked to ✅ Done in ibc-rs Feb 21, 2023
@Farhad-Shabani Farhad-Shabani removed the A: blocked Admin: blocked by another (internal/external) issue or PR label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: bug Admin: something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@plafer @Farhad-Shabani