Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async-tungstenite version too old #1165

Closed
mzabaluev opened this issue Jul 27, 2022 · 0 comments · Fixed by #1166
Closed

async-tungstenite version too old #1165

mzabaluev opened this issue Jul 27, 2022 · 0 comments · Fixed by #1166
Labels
bug Something isn't working dependencies Pull requests that update a dependency file rpc

Comments

@mzabaluev
Copy link
Contributor

Version(s) of tendermint-rs: v0.23.8, master

The version of async-tungstenite used by tendermint-rpc is 0.12, while 0.17,x is available.
One known issue with the older version manifests when trying to work with IPv6: https://github.com/informalsystems/ibc-rs/issues/2380

Definition of "done"

async-tungstenite is updated to 0.17.x, so that client connections to URLs like "ws://[::1]:27030/websocket" can be formed without error.
@mzabaluev mzabaluev added bug Something isn't working dependencies Pull requests that update a dependency file rpc labels Jul 27, 2022
@mzabaluev mzabaluev mentioned this issue Jul 27, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working dependencies Pull requests that update a dependency file rpc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump async-tungstenite to 0.17 informalsystems/tendermint-rs
1 participant
@mzabaluev