Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add INK_RUNTIME and INK_EDITOR #defines so devs can safely remove references to ink code, if they need to #173

Closed
tomkail opened this issue Nov 1, 2022 · 2 comments
Closed

Add INK_RUNTIME and INK_EDITOR #defines so devs can safely remove references to ink code, if they need to #173

tomkail opened this issue Nov 1, 2022 · 2 comments
Labels
enhancement help wanted

Comments

@tomkail
Copy link
Collaborator

tomkail commented Nov 1, 2022 •
edited
Loading

I need to work out how to add and remove defines from ProjectSettings when the package is added/removed.
@tomkail tomkail changed the title Add ink #defines to Asmdef so devs can safely remove references to ink code, if they need to Add INK_RUNTIME and INK_EDITOR #defines so devs can safely remove references to ink code, if they need to Jul 14, 2023
@tomkail
Copy link
Collaborator Author

tomkail commented Jul 14, 2023

I've added some functions for this to InkEditorUtils, but more work is required to improve the UX; it should be automatic!

@tomkail
Copy link
Collaborator Author

tomkail commented Oct 3, 2023

This is now done.

@tomkail tomkail closed this as completed Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomkail