Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Management of dependencies edge cases #2737

Open
fgibertoni opened this issue Feb 14, 2025 · 8 comments
Open

Management of dependencies edge cases #2737

fgibertoni opened this issue Feb 14, 2025 · 8 comments
Assignees
Labels
dependencies Pull requests that update a dependency file integrations Issues regarding updates on various integrations with external tools / providers maintenance Issues that requires updating dependencies and overall modernity of the project

Comments

@fgibertoni
Copy link
Contributor

We have some dependencies that do not follow a strict versioning scheme or have some special usage. More about them can be found in @mlodic's #2736 mostly in code comments of edited files.

Another approach would be to create some GitHub workflows that are triggered by commits or releases on mentioned repositories. These workflow can then open PRs just like dependabot.

Let us know if any ideas come up and we can discuss them in this issue 😄

@mlodic mlodic changed the title Management of depencies edge cases Management of dependencies edge cases Feb 18, 2025
@ashknl
Copy link

ashknl commented Feb 20, 2025

The workflow idea sounds neat! Tho one problem would be how to figure out version bumps for repos that don't make new releases.

@fgibertoni
Copy link
Contributor Author

You're right.
My idea could be implemented as a polling (once a week like dependabot maybe ?) to the external repository to check for new pushes to main branch. What do you think about that ?

@ashknl
Copy link

ashknl commented Feb 23, 2025

Polling once a week seems good. We might have to also consider the fact that not all pushes will be code changes.

@fgibertoni
Copy link
Contributor Author

Would you like to try implementing the approach we discussed ? 😄

@ashknl
Copy link

ashknl commented Feb 25, 2025

I would love to! I am new to the intelowl project tho, so it might take me a while to learn the codebase and the contribution workflow.

@fgibertoni
Copy link
Contributor Author

That's not a problem at all! I can assign this issue to you and we have no time limits. We only ask for ping once every two weeks to be sure that the issue is not being abandoned by the assignee.
Also, you can open a draft PR and ask for help if something is missing from the doc or you're having some trouble.
Lmk if you're up for this 😉

@ashknl
Copy link

ashknl commented Feb 26, 2025

I am up for it then!
Fwiw, a github workflow that runs on a commit/code push to main (or a release for the repos that do make one) is the expected PR for this, right?

@fgibertoni
Copy link
Contributor Author

Yeah it should be good in my opinion. I think you'll have to go through each repository to see how they release code and adapt the workflow for the requirement.
I'll assign this to you! Let us know if you're in doubt 😄

@fgibertoni fgibertoni added dependencies Pull requests that update a dependency file maintenance Issues that requires updating dependencies and overall modernity of the project integrations Issues regarding updates on various integrations with external tools / providers labels Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file integrations Issues regarding updates on various integrations with external tools / providers maintenance Issues that requires updating dependencies and overall modernity of the project
Projects
None yet
Development

No branches or pull requests

2 participants