Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeZones Dependency #161

Closed
ccoffrin opened this issue May 1, 2020 · 7 comments
Closed

TimeZones Dependency #161

ccoffrin opened this issue May 1, 2020 · 7 comments

Comments

@ccoffrin
Copy link

ccoffrin commented May 1, 2020

Might it be possible to drop the dependency on TimeZones? It's build process has been problematic from time to time and it pulls down this file "https://data.iana.org/time-zones/releases/tzdata2019c.tar.gz" which represents non-github hosted data that isn't tracked by the Julia package manager.

@rofinn
Copy link
Member

rofinn commented May 1, 2020

I'll redirect this to @omus. I feel like the TimeZones.jl build process should just be fixed. Otherwise, it's a pretty light package... and we do find it helpful to have timezone aware timestamps. There has been a discussion of providing a Minimento.jl (for lack of a better name) package that doesn't have any dependencies, but I think at that point it'd be better to just add the functionality we want to the Logging stdlib.

@omus
Copy link
Contributor

omus commented May 1, 2020

I've been thinking about using Julia artifacts to store the tzdata which would also address this problem. Out of curiosity, what is problematic about the build process?

@ccoffrin
Copy link
Author

ccoffrin commented May 1, 2020

Over the years it was breaking from time to time, I think the wget/curl call would break due to some proxy issue on my side, which was breaking and fixed at random.

A big advantage of a github-only solution is that the git protocol can be used to pull down all of the data which is friendly with various proxies and filters that I encounter.

@ccoffrin
Copy link
Author

ccoffrin commented May 1, 2020

If Julia artifacts is a viable solution, that sounds good to me!

@racinmat
Copy link

TimeZones now use Artifacts https://github.com/JuliaTime/TimeZones.jl/releases/tag/v1.3.0

@rofinn
Copy link
Member

rofinn commented Jul 17, 2020

Looks like we should already support that version, so I’ll close this. Please re-open if you run into further issues.

@rofinn rofinn closed this as completed Jul 17, 2020
@ccoffrin
Copy link
Author

Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants