Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more IPNS record tests based on IPIP-428 #144

Closed
7 tasks done
lidel opened this issue Aug 17, 2023 · 1 comment · Fixed by #157
Closed
7 tasks done

Add more IPNS record tests based on IPIP-428 #144

lidel opened this issue Aug 17, 2023 · 1 comment · Fixed by #157
Assignees
Labels
test:coverage Improves the spec covered by this test suite

Comments

@lidel
Copy link
Member

lidel commented Aug 17, 2023

Ref. ipfs/specs#428 tldr: we should have .ipns-record files with fixtures for:

  • V1-only → record invalid (gateway returns 5XX error)
  • V1+V2 (both signatures valid) → record valid, HTTP 200
  • V1+V2 (both signatures valid, but 'value' is different in V1 pb) → record invalid (gateway returns 5XX error)
  • V1+V2 (only signatureV1 valid) → record invalid (gateway returns 5XX error)
  • V1+V2 (only signatureV2 valid) → record valid, HTTP 200
  • V2-only (no V1 fields) → record valid, HTTP 200
  • update IPIP-428 and include links to mentioned fixtures from this PR

This will be an extremely useful resource for anyone trying to implement IPNS, as they would be able to either run gateway-conformance, or at least reuse related fixtures.

@lidel lidel added the test:coverage Improves the spec covered by this test suite label Aug 17, 2023
@lidel lidel moved this to 🥞 Todo in IPFS Shipyard Team Aug 24, 2023
@lidel
Copy link
Member Author

lidel commented Sep 7, 2023

This is blocking ipfs/specs#428 from being merged.
@hacdias would you be able to tackle this before diving into unixfs?
(since you've done GO and JS implementation of IPIP-428 and have the relevant context)

@hacdias hacdias moved this from 🥞 Todo to 🏃‍♀️ In Progress in IPFS Shipyard Team Sep 7, 2023
@github-project-automation github-project-automation bot moved this from 🏃‍♀️ In Progress to 🎉 Done in IPFS Shipyard Team Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test:coverage Improves the spec covered by this test suite
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants