Separated deprecated code. (rpgtex#245)

* Separated deprecated code

Author: BrianCriswell

dndcore.def

@@ -13,13 +13,11 @@
 \RequirePackage {etoolbox}
 \RequirePackage {textcomp,gensymb} % degree symbol for italian ordinals
 \RequirePackage {hang} % hanging paragraphs
-\RequirePackage {keycommand}
 \RequirePackage [autolanguage] {numprint} % localization of thousands separator
 \RequirePackage {tabularx} % variable-width table columns
 \RequirePackage [breakable,skins,xparse]{tcolorbox} % styled text boxes
 \RequirePackage {tikz} % drawing ornaments and lines
 \RequirePackage {xcolor}
-\RequirePackage {xkeyval}
 \RequirePackage {xparse} % \NewDocumentCommand and expl3
 
 \sys_if_engine_luatex:T
@@ -77,16 +75,16 @@
 \RequirePackage {lib/dndcolors}     % color definitions
 \RequirePackage {lib/dndfonts}      % font definitions
 \RequirePackage {lib/dndstrings}    % Load document strings
-\RequirePackage {lib/dnddeprecated} % Deprecated macros
+
+% Conditionally load deprecated code for backwards compatibility
+\bool_if:NF \l__dnd_no_deprecated_code_bool
+  { \RequirePackage {lib/dnddeprecated} }
 
 % Main modules in alphabetical order
 \RequirePackage {lib/dndcomment}    % inline comment boxes
 \RequirePackage {lib/dndheader}     % fancy headers and footers
-\RequirePackage {lib/dndmonster}    % \monsterbox definition
-\RequirePackage {lib/dndpaperbox}   % \paperbox definition
-\RequirePackage {lib/dndquote}      % \quotebox definition
+\RequirePackage {lib/dndmonster}    % stat blocks
 \RequirePackage {lib/dndreadaloud}  % read-aloud text
-\RequirePackage {lib/dndsections}   % section styling
+\RequirePackage {lib/dndsections}   % section styling and special section headers
 \RequirePackage {lib/dndsidebar}    % sidebars
-\RequirePackage {lib/dndspell}      % \spell definition
-\RequirePackage {lib/dndtable}      % \dndtable definition
+\RequirePackage {lib/dndtable}      % tables

dndoptions.clo

@@ -30,6 +30,7 @@
 \bool_new:N \l__dnd_justified_bool
 \bool_new:N \l__dnd_multitoc_bool
 \bool_new:N \l__dnd_layout_bool
+\bool_new:N \l__dnd_no_deprecated_code_bool
 
 \bool_set_true:N \l__dnd_multitoc_bool
 \bool_set_eq:NN \l__dnd_layout_bool \c__dnd_isclass_bool
@@ -67,6 +68,13 @@
       },
     justified .value_forbidden:n = true,
 
+    % Suppress deprecated code
+    nodeprecatedcode .code:n =
+      {
+        \bool_set_true:N \l__dnd_no_deprecated_code_bool
+      },
+    nodeprecatedcode .value_forbidden:n = true,
+
     % Avoid multi-column toc
     nomultitoc .code:n =
       {

example.tex

@@ -1,4 +1,4 @@
-\documentclass[letterpaper,twocolumn,openany]{dndbook}
+\documentclass[letterpaper,twocolumn,openany,nodeprecatedcode]{dndbook}
 
 % Use babel or polyglossia to automatically redefine macros for terms
 % Armor Class, Level, etc...

lib/compat.sty

@@ -12,5 +12,3 @@
     %   https://github.com/latex3/latex3/blob/8fcb571ddda61c01773d9746d32cecdbe63afb26/l3kernel/l3obsolete.txt#L65
     \cs_new_eq:NN \str_case_e:nnF \str_case_x:nnF
   }
-
-\ExplSyntaxOff

lib/dndcolors.sty

@@ -41,30 +41,10 @@
 
 % Sets the themecolor and colors for all themed elements
 % If called without the optional color, resets the color of all themed elements to the current themecolor
-% Old interface
-\newcommand{\setthemecolor}[1][themecolor]{%
-  \colorlet{themecolor}{#1}
-  \colorlet{commentcolor}{#1}
-  \colorlet{sidebarcolor}{#1}
-  \colorlet{tablecolor}{#1}
-}
-
-% New interface
 \NewDocumentCommand {\DndSetThemeColor} { O {themecolor} }
   {
     \colorlet {themecolor}   {#1}
     \colorlet {commentcolor} {#1}
     \colorlet {sidebarcolor} {#1}
     \colorlet {tablecolor}   {#1}
   }
-
-% Backwards-compatible aliases and colours
-\colorlet {commentgreen}  {PhbLightGreen}
-\colorlet {itemtablepink} {DmgCoral}
-\colorlet {monstertan}    {statblockbg}
-\definecolor {monstertandark} {HTML} {F0DBB5}
-
-% Old interface
-\colorlet {commentboxcolor} {commentcolor}
-\colorlet {paperboxcolor}   {sidebarcolor}
-\colorlet {quoteboxcolor}   {readaloudcolor}

lib/dndcomment.sty

@@ -1,41 +1,5 @@
 \ExplSyntaxOn
 
-% Old interface
-%Usage \begin{commentbox}[options]{title}[color]
-\DeclareTColorBox{commentbox}{O{} m O{commentboxcolor}}{%
-  before~upper={%
-    \bool_if:NT \l__dnd_layout_bool
-      {
-        \bool_if:NF \l__dnd_justified_bool
-          { \RaggedRight }
-      }
-  },
-  code={\linespread{.9}},
-  frame~hidden,
-  boxrule=0pt,
-  breakable,
-  enhanced,
-  before~skip=13pt plus 4pt minus 4pt,
-  toptitle=2pt,
-  boxsep=3pt,
-  left=6pt,
-  right=6pt,
-  top=0pt,
-  bottom=2pt,
-  sharp~corners,
-  fonttitle=\DndFontCommentTitle,
-  fontupper=\DndFontCommentBody,
-  fontlower=\DndFontCommentBody,
-  title={#2},
-  parbox=false,
-  colback=#3,
-  colbacktitle=#3,
-  coltitle=black,
-  after~skip=13pt plus 4pt minus 4pt,
-  #1
-}
-
-% New interface
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 % Environment for comments.
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%