Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update doc/self-hosted-runners GitHub App instructions #284

Open
dacbd opened this issue Jul 26, 2022 · 5 comments
Open

update doc/self-hosted-runners GitHub App instructions #284

dacbd opened this issue Jul 26, 2022 · 5 comments
Labels
documentation Markdown files external-request You asked, we did p1-important High priority

Comments

@dacbd
Copy link
Contributor

dacbd commented Jul 26, 2022

Cross-link: #388

@dacbd dacbd closed this as not planned Won't fix, can't repro, duplicate, stale Jul 26, 2022
@dacbd dacbd reopened this Jul 26, 2022
@dacbd dacbd added documentation Markdown files p1-important High priority external-request You asked, we did p0-critical Max priority (ASAP) and removed p1-important High priority labels Jul 26, 2022
@dacbd
Copy link
Contributor Author

dacbd commented Jul 26, 2022

p0 label as instructions result in an un-usable runner

@jorgeorpinel
Copy link
Contributor

Hi. What instructions does this refer to? A summary of the docs-specific task would be nice. Thanks

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Sep 21, 2022

Cross-link: #388

Should there be any more cross-links based on https://github.com/iterative/cml/labels/documentation (since that repo does not use the same A: docs label) ?

@dacbd
Copy link
Contributor Author

dacbd commented Sep 21, 2022

the link provides the context for what is needed to update, there is an action scope that should be included when setting up the app/action used to generate ephemeral GitHub tokens https://cml.dev/doc/self-hosted-runners#app

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Sep 22, 2022

It's a pretty long conversation in that link. I think we want readable and actionable docs issues for planning, etc. Imagine someone (maybe even yourself) opens this in a year and wants to quickly understand the task and scope.

there is an action scope that should be included when setting up the app/action used to generate ephemeral GitHub tokens

So is that the summary? Should we add it to the issue description if so? What action scope is it? Where is it set up? Thanks

@casperdcl casperdcl mentioned this issue Nov 29, 2022
4 tasks
@casperdcl casperdcl removed the p0-critical Max priority (ASAP) label Dec 20, 2022
@dacbd dacbd added the p1-important High priority label Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Markdown files external-request You asked, we did p1-important High priority
Projects
None yet
Development

No branches or pull requests

3 participants