Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Automated testing when merging to main #681

Closed
davesteps opened this issue Jul 29, 2021 · 4 comments
Closed

Feature Request: Automated testing when merging to main #681

davesteps opened this issue Jul 29, 2021 · 4 comments
Labels
discussion Waiting for team decision enhancement New feature or request

Comments

@davesteps
Copy link

If we assume our currently deployed model is on the main branch. When we train a better model on a new branch and we decide to merge into main, we want to run some CI/CD tests that will confirm our branch is ok to merge. In particular we want to test that 1) all of the dvc tracked files have been pushed to the remote and 2) if you run dvc status it return something like ‘All data and pipeline up to date.’. We have set up some python tests to confirm this but it doesn’t seem the most robust. Could there be some CML function to do this in a more formal way?

FYI I asked this on he forum and was asked to open it as an issue.

Thanks.

@DavidGOrtega
Copy link
Contributor

@davesteps thanks for the feature

@davesteps
Copy link
Author

I think this would actually be covered by the dvc feature discussed here: iterative/dvc#5369

@DavidGOrtega DavidGOrtega added discussion Waiting for team decision enhancement New feature or request labels Aug 2, 2021
@dacbd
Copy link
Contributor

dacbd commented Jun 10, 2022

Closing in favo[u]r of the DVC issue (iterative/dvc#5369), @davesteps if you want CML to revisit this feel free to reopen here :)

@dacbd dacbd closed this as not planned Won't fix, can't repro, duplicate, stale Jun 10, 2022
@casperdcl
Copy link
Contributor

casperdcl commented Jun 16, 2022

I assume the end goal would be something like:

cml send-github-check --status queued
pip install ...
cml send-github-check --status in_progress
dvc verify && cml send-github-check --conclusion success || cml send-github-check --conclusion failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Waiting for team decision enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants