GitHub–hosted runners have taken over the RUNNER_ environment variable prefix

[0x2b3bfa0]

Suddenly, GitHub–hosted runners have started to set environment variables with the RUNNER_ prefix, clashing with the ones we're using on cml runner to let users specify command–line options through the environment:

cml/bin/cml/runner.js

Line 12 in 7d664ae

const NAME = `cml-${randid()}`;

cml/bin/cml/runner.js

Lines 17 to 28 in 7d664ae

	RUNNER_PATH = `${WORKDIR_BASE}/${NAME}`,
	RUNNER_IDLE_TIMEOUT = 5 * 60,
	RUNNER_DESTROY_DELAY = 20,
	RUNNER_LABELS = 'cml',
	RUNNER_NAME = NAME,
	RUNNER_SINGLE = false,
	RUNNER_REUSE = false,
	RUNNER_NO_RETRY = false,
	RUNNER_DRIVER,
	RUNNER_REPO,
	REPO_TOKEN
	} = process.env;

Among others, GitHub–hosted runners are setting RUNNER_NAME to esoteric values with uppercase and spaces like GitHub Actions 3, causing some cloud vendors to break in unexpected ways.

For example, Google Cloud complains loudly and refuses to create any resources with names containing whitespace:

Error: Failed creating the machine: googleapi: Error 400: Invalid value for field 'resource.name': 'GitHub Actions 2-egress'. Must be a match of regex '(?:[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?)'

More details:
  Reason: invalid, Message: Invalid value for field 'resource.name': 'GitHub Actions 2-egress'. Must be a match of
regex '(?:[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?)'
  Reason: invalid, Message: Invalid value for field 'resource.targetTags[0]': 'GitHub Actions 2'. Must be a match o
f regex '(?:[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?)'

AWS also fails because of this, as per #741

Minimal working example

Workflow

on: workflow_dispatch
jobs:
  test:
    runs-on: ubuntu-latest
    steps:
      - run: env | grep ^RUNNER_

Output

RUNNER_NAME=GitHub Actions 3
RUNNER_OS=Linux
RUNNER_TRACKING_ID=github_···
RUNNER_TEMP=/home/runner/work/_temp
RUNNER_USER=runner
RUNNER_TOOL_CACHE=/opt/hostedtoolcache
RUNNER_WORKSPACE=/home/runner/work/test
RUNNER_PERFLOG=/home/runner/perflog

[dacbd]

┬──┬ ¯_(ツ)

┻┻︵ヽ(`Д´)ﾉ︵┻┻

[0x2b3bfa0]

Also seen on #741