Skip to content

Commit 08b825b

Browse files
committed
Merge branch 'master' into allowed-index-store-types
* master: Fix ordering of bootstrap checks in docs (elastic#32417) [TEST] Mute failing InternalEngineTests#testSeqNoAndCheckpoints [TEST] Mute failing testConvertLongHexError bump lucene version after backport Upgrade to Lucene-7.5.0-snapshot-608f0277b0 (elastic#32390) [Kerberos] Avoid vagrant update on precommit (elastic#32416)
2 parents 4f74cd0 + 3ac57f0 commit 08b825b

File tree

65 files changed

+106
-117
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

65 files changed

+106
-117
lines changed

buildSrc/version.properties

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
elasticsearch = 7.0.0-alpha1
2-
lucene = 7.4.0
2+
lucene = 7.5.0-snapshot-608f0277b0
33

44
# optional dependencies
55
spatial4j = 0.7

docs/Versions.asciidoc

+2-2

docs/reference/setup/bootstrap-checks.asciidoc

+13-13

modules/ingest-common/src/test/java/org/elasticsearch/ingest/common/ConvertProcessorTests.java

+7-6
Original file line numberDiff line numberDiff line change
@@ -19,24 +19,24 @@
1919

2020
package org.elasticsearch.ingest.common;
2121

22-
import org.elasticsearch.ingest.IngestDocument;
23-
import org.elasticsearch.ingest.Processor;
24-
import org.elasticsearch.ingest.RandomDocumentPicks;
25-
import org.elasticsearch.test.ESTestCase;
26-
2722
import java.util.ArrayList;
2823
import java.util.Collections;
2924
import java.util.HashMap;
3025
import java.util.List;
3126
import java.util.Locale;
3227
import java.util.Map;
3328

29+
import org.elasticsearch.ingest.IngestDocument;
30+
import org.elasticsearch.ingest.Processor;
31+
import org.elasticsearch.ingest.RandomDocumentPicks;
32+
import org.elasticsearch.test.ESTestCase;
33+
3434
import static org.elasticsearch.ingest.IngestDocumentMatcher.assertIngestDocument;
3535
import static org.elasticsearch.ingest.common.ConvertProcessor.Type;
3636
import static org.hamcrest.Matchers.containsString;
3737
import static org.hamcrest.Matchers.equalTo;
38-
import static org.hamcrest.Matchers.sameInstance;
3938
import static org.hamcrest.Matchers.not;
39+
import static org.hamcrest.Matchers.sameInstance;
4040

4141
public class ConvertProcessorTests extends ESTestCase {
4242

@@ -138,6 +138,7 @@ public void testConvertLongLeadingZero() throws Exception {
138138
assertThat(ingestDocument.getFieldValue(fieldName, Long.class), equalTo(10L));
139139
}
140140

141+
@AwaitsFix( bugUrl = "https://github.com/elastic/elasticsearch/issues/32370")
141142
public void testConvertLongHexError() {
142143
IngestDocument ingestDocument = RandomDocumentPicks.randomIngestDocument(random());
143144
String value = "0x" + randomAlphaOfLengthBetween(1, 10);

modules/lang-expression/licenses/lucene-expressions-7.4.0.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
bd7d8078a2d0ad11a24f54156cc015630c96858a

plugins/analysis-icu/build.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ forbiddenApis {
3030

3131
dependencies {
3232
compile "org.apache.lucene:lucene-analyzers-icu:${versions.lucene}"
33-
compile 'com.ibm.icu:icu4j:61.1'
33+
compile 'com.ibm.icu:icu4j:62.1'
3434
}
3535

3636
dependencyLicenses {

plugins/analysis-icu/licenses/icu4j-61.1.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
7a4d00d5ec5febd252a6182e8b6e87a0a9821f81

plugins/analysis-icu/licenses/lucene-analyzers-icu-7.4.0.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
7a37816def72a748416c4ae8b0f6817e30efb99f

plugins/analysis-kuromoji/licenses/lucene-analyzers-kuromoji-7.4.0.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
ca7437178cdbf7b8bfe0d75c75e3c8eb93925724

plugins/analysis-nori/licenses/lucene-analyzers-nori-7.4.0.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
3f5dec44f380d6d58bc1c8aec51964fcb5390b60

plugins/analysis-phonetic/licenses/lucene-analyzers-phonetic-7.4.0.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
453bf1d60df0415439095624e0b3e42492ad4716

plugins/analysis-smartcn/licenses/lucene-analyzers-smartcn-7.4.0.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
70095a45257bca9f46629b5fb6cedf9eff5e2b07

plugins/analysis-stempel/licenses/lucene-analyzers-stempel-7.4.0.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
7199d6962d268b7877f7b5160e98e4ff21cce5c7

plugins/analysis-ukrainian/licenses/lucene-analyzers-morfologik-7.4.0.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
12aff508d39d206a1aead5013ecd11882062eb06

plugins/store-smb/src/test/java/org/elasticsearch/index/store/SmbMMapDirectoryTests.java

+8
Original file line numberDiff line numberDiff line change
@@ -30,4 +30,12 @@ public class SmbMMapDirectoryTests extends EsBaseDirectoryTestCase {
3030
protected Directory getDirectory(Path file) throws IOException {
3131
return new SmbDirectoryWrapper(new MMapDirectory(file));
3232
}
33+
34+
@Override
35+
public void testCreateOutputForExistingFile() throws IOException {
36+
/**
37+
* This test is disabled because {@link SmbDirectoryWrapper} opens existing file
38+
* with an explicit StandardOpenOption.TRUNCATE_EXISTING option.
39+
*/
40+
}
3341
}

plugins/store-smb/src/test/java/org/elasticsearch/index/store/SmbSimpleFSDirectoryTests.java

+8
Original file line numberDiff line numberDiff line change
@@ -30,4 +30,12 @@ public class SmbSimpleFSDirectoryTests extends EsBaseDirectoryTestCase {
3030
protected Directory getDirectory(Path file) throws IOException {
3131
return new SmbDirectoryWrapper(new SimpleFSDirectory(file));
3232
}
33+
34+
@Override
35+
public void testCreateOutputForExistingFile() throws IOException {
36+
/**
37+
* This test is disabled because {@link SmbDirectoryWrapper} opens existing file
38+
* with an explicit StandardOpenOption.TRUNCATE_EXISTING option.
39+
*/
40+
}
3341
}

server/licenses/lucene-analyzers-common-7.4.0.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
d27958843ca118db2ffd2c242ae3761bd5a47328

server/licenses/lucene-backward-codecs-7.4.0.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
7ea220ba8e4accb8b04e280463042ad470e23bc0

server/licenses/lucene-core-7.4.0.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
471096d6e92338b208aa91f3a85feb2f9cfc4afd

server/licenses/lucene-grouping-7.4.0.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
f0af947c60d24f779c22f774e81ebd7dd91cc932

server/licenses/lucene-highlighter-7.4.0.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
fbc83ac5a0139ed7e7faf6c95a2718f46f28c641

server/licenses/lucene-join-7.4.0.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
30adfe493982b0db059dc243e269eea38d850d46

server/licenses/lucene-memory-7.4.0.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
656f304261d9aad05070fb68593beffafe9147e3

server/licenses/lucene-misc-7.4.0.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
8bf22ad81a7480c255b55bada401eb131bfdb4df

server/licenses/lucene-queries-7.4.0.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
edb3de4d68a34c1e1ca08f79fe4d103b10e98ad1

server/licenses/lucene-queryparser-7.4.0.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
7ece30d5f1e18d96f61644451c858c3d9960558f

server/licenses/lucene-sandbox-7.4.0.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
ad3bd0c2ed96556193c7215bef328e689d0b157f

server/licenses/lucene-spatial-7.4.0.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
8a6bd97e39ee5af60126adbe8c8375dc41b1ea8e

server/licenses/lucene-spatial-extras-7.4.0.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
07e748d2d80000a7a213f3405b82b6e26b452948

server/licenses/lucene-spatial3d-7.4.0.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
fd737bd5562f3943618ee7e73a0aaffb6319fdb2

server/licenses/lucene-suggest-7.4.0.jar.sha1

-1
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
ff3f260d1dc8c18bc67f3c33aa84a0ad290daac5

server/src/main/java/org/elasticsearch/Version.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -179,10 +179,10 @@ public class Version implements Comparable<Version>, ToXContentFragment {
179179
public static final int V_6_4_0_ID = 6040099;
180180
public static final Version V_6_4_0 = new Version(V_6_4_0_ID, org.apache.lucene.util.Version.LUCENE_7_4_0);
181181
public static final int V_6_5_0_ID = 6050099;
182-
public static final Version V_6_5_0 = new Version(V_6_5_0_ID, org.apache.lucene.util.Version.LUCENE_7_4_0);
182+
public static final Version V_6_5_0 = new Version(V_6_5_0_ID, org.apache.lucene.util.Version.LUCENE_7_5_0);
183183
public static final int V_7_0_0_alpha1_ID = 7000001;
184184
public static final Version V_7_0_0_alpha1 =
185-
new Version(V_7_0_0_alpha1_ID, org.apache.lucene.util.Version.LUCENE_7_4_0);
185+
new Version(V_7_0_0_alpha1_ID, org.apache.lucene.util.Version.LUCENE_7_5_0);
186186
public static final Version CURRENT = V_7_0_0_alpha1;
187187

188188
static {

server/src/main/java/org/elasticsearch/index/EsTieredMergePolicy.java

+1-10
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public MergeSpecification findForcedMerges(SegmentInfos infos, int maxSegmentCou
5252

5353
@Override
5454
public MergeSpecification findForcedDeletesMerges(SegmentInfos infos, MergeContext mergeContext) throws IOException {
55-
return forcedMergePolicy.findForcedDeletesMerges(infos, mergeContext);
55+
return forcedMergePolicy.findForcedDeletesMerges(infos, mergeContext);
5656
}
5757

5858
public void setForceMergeDeletesPctAllowed(double forceMergeDeletesPctAllowed) {
@@ -108,13 +108,4 @@ public void setSegmentsPerTier(double segmentsPerTier) {
108108
public double getSegmentsPerTier() {
109109
return regularMergePolicy.getSegmentsPerTier();
110110
}
111-
112-
public void setReclaimDeletesWeight(double reclaimDeletesWeight) {
113-
regularMergePolicy.setReclaimDeletesWeight(reclaimDeletesWeight);
114-
forcedMergePolicy.setReclaimDeletesWeight(reclaimDeletesWeight);
115-
}
116-
117-
public double getReclaimDeletesWeight() {
118-
return regularMergePolicy.getReclaimDeletesWeight();
119-
}
120111
}

server/src/main/java/org/elasticsearch/index/IndexSettings.java

-1
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,6 @@ public IndexSettings(final IndexMetaData indexMetaData, final Settings nodeSetti
416416
scopedSettings.addSettingsUpdateConsumer(MergePolicyConfig.INDEX_MERGE_POLICY_MAX_MERGE_AT_ONCE_EXPLICIT_SETTING, mergePolicyConfig::setMaxMergesAtOnceExplicit);
417417
scopedSettings.addSettingsUpdateConsumer(MergePolicyConfig.INDEX_MERGE_POLICY_MAX_MERGED_SEGMENT_SETTING, mergePolicyConfig::setMaxMergedSegment);
418418
scopedSettings.addSettingsUpdateConsumer(MergePolicyConfig.INDEX_MERGE_POLICY_SEGMENTS_PER_TIER_SETTING, mergePolicyConfig::setSegmentsPerTier);
419-
scopedSettings.addSettingsUpdateConsumer(MergePolicyConfig.INDEX_MERGE_POLICY_RECLAIM_DELETES_WEIGHT_SETTING, mergePolicyConfig::setReclaimDeletesWeight);
420419

421420
scopedSettings.addSettingsUpdateConsumer(MergeSchedulerConfig.MAX_THREAD_COUNT_SETTING, MergeSchedulerConfig.MAX_MERGE_COUNT_SETTING,
422421
mergeSchedulerConfig::setMaxThreadAndMergeCount);

server/src/main/java/org/elasticsearch/index/MergePolicyConfig.java

+1-6
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ public final class MergePolicyConfig {
150150
Property.Dynamic, Property.IndexScope);
151151
public static final Setting<Double> INDEX_MERGE_POLICY_RECLAIM_DELETES_WEIGHT_SETTING =
152152
Setting.doubleSetting("index.merge.policy.reclaim_deletes_weight", DEFAULT_RECLAIM_DELETES_WEIGHT, 0.0d,
153-
Property.Dynamic, Property.IndexScope);
153+
Property.Dynamic, Property.IndexScope, Property.Deprecated);
154154
public static final String INDEX_MERGE_ENABLED = "index.merge.enabled"; // don't convert to Setting<> and register... we only set this in tests and register via a plugin
155155

156156

@@ -176,17 +176,12 @@ public final class MergePolicyConfig {
176176
mergePolicy.setMaxMergeAtOnceExplicit(maxMergeAtOnceExplicit);
177177
mergePolicy.setMaxMergedSegmentMB(maxMergedSegment.getMbFrac());
178178
mergePolicy.setSegmentsPerTier(segmentsPerTier);
179-
mergePolicy.setReclaimDeletesWeight(reclaimDeletesWeight);
180179
if (logger.isTraceEnabled()) {
181180
logger.trace("using [tiered] merge mergePolicy with expunge_deletes_allowed[{}], floor_segment[{}], max_merge_at_once[{}], max_merge_at_once_explicit[{}], max_merged_segment[{}], segments_per_tier[{}], reclaim_deletes_weight[{}]",
182181
forceMergeDeletesPctAllowed, floorSegment, maxMergeAtOnce, maxMergeAtOnceExplicit, maxMergedSegment, segmentsPerTier, reclaimDeletesWeight);
183182
}
184183
}
185184

186-
void setReclaimDeletesWeight(Double reclaimDeletesWeight) {
187-
mergePolicy.setReclaimDeletesWeight(reclaimDeletesWeight);
188-
}
189-
190185
void setSegmentsPerTier(Double segmentsPerTier) {
191186
mergePolicy.setSegmentsPerTier(segmentsPerTier);
192187
}

server/src/test/java/org/elasticsearch/index/EsTieredMergePolicyTests.java

+2-10
Original file line numberDiff line numberDiff line change
@@ -29,16 +29,14 @@ public void testDefaults() {
2929
assertEquals(
3030
new TieredMergePolicy().getMaxMergedSegmentMB(),
3131
policy.regularMergePolicy.getMaxMergedSegmentMB(), 0d);
32-
// TODO: fix when incorporating https://issues.apache.org/jira/browse/LUCENE-8398, the first divisor must be a double
33-
assertEquals(Long.MAX_VALUE / 1024 / 1024.0, policy.forcedMergePolicy.getMaxMergedSegmentMB(), 0d);
32+
assertEquals(Long.MAX_VALUE / 1024.0 / 1024.0, policy.forcedMergePolicy.getMaxMergedSegmentMB(), 0d);
3433
}
3534

3635
public void testSetMaxMergedSegmentMB() {
3736
EsTieredMergePolicy policy = new EsTieredMergePolicy();
3837
policy.setMaxMergedSegmentMB(10 * 1024);
3938
assertEquals(10 * 1024, policy.regularMergePolicy.getMaxMergedSegmentMB(), 0d);
40-
// TODO: fix when incorporating https://issues.apache.org/jira/browse/LUCENE-8398, the first divisor must be a double
41-
assertEquals(Long.MAX_VALUE / 1024 / 1024.0, policy.forcedMergePolicy.getMaxMergedSegmentMB(), 0d);
39+
assertEquals(Long.MAX_VALUE / 1024.0 / 1024.0, policy.forcedMergePolicy.getMaxMergedSegmentMB(), 0d);
4240
}
4341

4442
public void testSetForceMergeDeletesPctAllowed() {
@@ -71,10 +69,4 @@ public void testSetSegmentsPerTier() {
7169
policy.setSegmentsPerTier(42);
7270
assertEquals(42, policy.regularMergePolicy.getSegmentsPerTier(), 0);
7371
}
74-
75-
public void testSetReclaimDeletesWeight() {
76-
EsTieredMergePolicy policy = new EsTieredMergePolicy();
77-
policy.setReclaimDeletesWeight(42);
78-
assertEquals(42, policy.regularMergePolicy.getReclaimDeletesWeight(), 0);
79-
}
8072
}

server/src/test/java/org/elasticsearch/index/MergePolicySettingsTests.java

-5
Original file line numberDiff line numberDiff line change
@@ -96,10 +96,6 @@ public void testTieredMergePolicySettingsUpdate() throws IOException {
9696
indexSettings.updateIndexMetaData(newIndexMeta("index", Settings.builder().put(MergePolicyConfig.INDEX_MERGE_POLICY_MAX_MERGED_SEGMENT_SETTING.getKey(), new ByteSizeValue(MergePolicyConfig.DEFAULT_MAX_MERGED_SEGMENT.getBytes() + 1)).build()));
9797
assertEquals(((EsTieredMergePolicy) indexSettings.getMergePolicy()).getMaxMergedSegmentMB(), new ByteSizeValue(MergePolicyConfig.DEFAULT_MAX_MERGED_SEGMENT.getBytes() + 1).getMbFrac(), 0.0001);
9898

99-
assertEquals(((EsTieredMergePolicy) indexSettings.getMergePolicy()).getReclaimDeletesWeight(), MergePolicyConfig.DEFAULT_RECLAIM_DELETES_WEIGHT, 0);
100-
indexSettings.updateIndexMetaData(newIndexMeta("index", Settings.builder().put(MergePolicyConfig.INDEX_MERGE_POLICY_RECLAIM_DELETES_WEIGHT_SETTING.getKey(), MergePolicyConfig.DEFAULT_RECLAIM_DELETES_WEIGHT + 1).build()));
101-
assertEquals(((EsTieredMergePolicy) indexSettings.getMergePolicy()).getReclaimDeletesWeight(), MergePolicyConfig.DEFAULT_RECLAIM_DELETES_WEIGHT + 1, 0);
102-
10399
assertEquals(((EsTieredMergePolicy) indexSettings.getMergePolicy()).getSegmentsPerTier(), MergePolicyConfig.DEFAULT_SEGMENTS_PER_TIER, 0);
104100
indexSettings.updateIndexMetaData(newIndexMeta("index", Settings.builder().put(MergePolicyConfig.INDEX_MERGE_POLICY_SEGMENTS_PER_TIER_SETTING.getKey(), MergePolicyConfig.DEFAULT_SEGMENTS_PER_TIER + 1).build()));
105101
assertEquals(((EsTieredMergePolicy) indexSettings.getMergePolicy()).getSegmentsPerTier(), MergePolicyConfig.DEFAULT_SEGMENTS_PER_TIER + 1, 0);
@@ -110,7 +106,6 @@ public void testTieredMergePolicySettingsUpdate() throws IOException {
110106
assertEquals(((EsTieredMergePolicy) indexSettings.getMergePolicy()).getMaxMergeAtOnce(), MergePolicyConfig.DEFAULT_MAX_MERGE_AT_ONCE);
111107
assertEquals(((EsTieredMergePolicy) indexSettings.getMergePolicy()).getMaxMergeAtOnceExplicit(), MergePolicyConfig.DEFAULT_MAX_MERGE_AT_ONCE_EXPLICIT);
112108
assertEquals(((EsTieredMergePolicy) indexSettings.getMergePolicy()).getMaxMergedSegmentMB(), new ByteSizeValue(MergePolicyConfig.DEFAULT_MAX_MERGED_SEGMENT.getBytes() + 1).getMbFrac(), 0.0001);
113-
assertEquals(((EsTieredMergePolicy) indexSettings.getMergePolicy()).getReclaimDeletesWeight(), MergePolicyConfig.DEFAULT_RECLAIM_DELETES_WEIGHT, 0);
114109
assertEquals(((EsTieredMergePolicy) indexSettings.getMergePolicy()).getSegmentsPerTier(), MergePolicyConfig.DEFAULT_SEGMENTS_PER_TIER, 0);
115110
}
116111

0 commit comments

Comments
 (0)