Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

struct highlight bug . #61

Closed
peaceshi opened this issue Apr 7, 2019 · 7 comments
Closed

struct highlight bug . #61

peaceshi opened this issue Apr 7, 2019 · 7 comments
Labels
✨ Enhancement New feature or request Hard Nearly Impossible :( Things that likely need more than just Textmate matching to fix

Comments

@peaceshi
Copy link
Contributor

peaceshi commented Apr 7, 2019

image
image

        {
            "name": "entity.name.type.struct",
            "scope": [
                "source.cpp entity.name.type.struct" // name of thing you want to color
            ],
            "settings": {
                "foreground":  "#29e6c6", // color you want it to be
                "fontStyle": "", // bold/underline/italics or none
            }
        },
@matter123
Copy link
Collaborator

This is a duplicate of #39. Vscode does single line matching. The grammar has no way of knowing that SYSTEMTIME is a type. fixing this would require vscode switch to a different tokenizer, say tree-sitter or letting the language service provider, provide the tokenization.

@matter123
Copy link
Collaborator

matter123 commented Apr 7, 2019

Sorry, I think I was mistaken, only A B(C) is ambiguous. A B should always be <type> <value>.

@matter123 matter123 reopened this Apr 7, 2019
@matter123 matter123 added Hard Nearly Impossible :( Things that likely need more than just Textmate matching to fix ✨ Enhancement New feature or request 🔍 investigating More information is being gathered labels Apr 7, 2019
@matter123
Copy link
Collaborator

In the expressions:

  1. A B
  2. A B(C)
  3. A B{C}

A is always a type
B is a always variable in 1 and 3, and either a variable or a function in 2
C is a value in 3 and either a type or a value in 2.

A should be safe to tag but B and C are not.

@jeff-hykin
Copy link
Owner

@peaceshi Could you add a bit more clarification?
What would be different if the bug didn't exist? (what tag would be added/removed from which piece of text)

@jeff-hykin
Copy link
Owner

@matter123 Do you understand this issue? I'm still not sure what needs to be fixed here.

@matter123
Copy link
Collaborator

::SYSTEMTIME is not tagged as a type.

@matter123
Copy link
Collaborator

Closing in favor of #71.

@matter123 matter123 removed the 🔍 investigating More information is being gathered label Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Enhancement New feature or request Hard Nearly Impossible :( Things that likely need more than just Textmate matching to fix
Projects
None yet
Development

No branches or pull requests

3 participants