Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Microsoft Explorer 11 #247

Closed
kminito opened this issue May 29, 2018 · 5 comments
Closed

Support Microsoft Explorer 11 #247

kminito opened this issue May 29, 2018 · 5 comments

Comments

@kminito
Copy link
Contributor

kminito commented May 29, 2018

Hi,
I'm using minima template, but recently I found that there is an overlapping problem when seen in Internet Explorer as below.
On Chrome and MS Edge, it works well. but on Explorer (version 11).

Is there anyone has same problem like me?
Please help..!

image

@kminito
Copy link
Contributor Author

kminito commented Jun 1, 2018

@adunning
Hello, I've visited some blogs using 'minima theme' to check the bug, and all of them have same issue as above.
But I found that your web page works well without any problem.

Could you give me some advice to fix this problem?
I hope that this is not rude to you..

@DirtyF DirtyF changed the title footer overlapping issue in Explorer Support Microsoft Explorer 11 Jun 1, 2018
@DirtyF
Copy link
Member

DirtyF commented Jun 1, 2018

@kminito It's likely to be related to the fact minima uses flexbox to make the footer stick.

@adunning
Copy link
Contributor

adunning commented Jun 5, 2018

The only thing I can think of (haven't tested it) is that I removed the <data/> line in https://github.com/jekyll/minima/blob/master/_includes/footer.html, which stops the page from validating (there is an open pull request to fix this). But I would be surprised if this is the root cause.

@kminito
Copy link
Contributor Author

kminito commented Jun 5, 2018

I solved this problem by changing flex properties of page-content in _layout.scs

flex: 1; -> flex: 1 0 auto;

@DirtyF thank you..!

@parkr
Copy link
Member

parkr commented Jun 16, 2018

#248 is merged.

@parkr parkr closed this as completed Jun 16, 2018
@jekyll jekyll locked and limited conversation to collaborators Jun 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants