Skip to content

Commit 59e472f

Browse files
Christopher-Chianellitriceo
authored andcommitted
Fix runQuickstartsFromSource.bat
Commit 35912dd updated `.sh` version of the script to run from ".." but ran the `.bat` version of the script from ".", which leads to "mvnw.cmd" not being found. Because of this, the quickstart launcher does not build or launch in Windows using runQuickstartsFromSource.bat. After this fix, the quickstart launcher does build and launch. However, there is still an issue where the quickstarts do not launch on Windows, complaining "mvnw" not being found (despite the path in the error existing). This issue would need to be fixed in the Java files. In regards to the many cd commands: Windows does not revert the working directory to it previous state after running commands. So `mvnw -f ..` changes the working directory back to the parent, so we need to back into build again. And then an extra cd to get out of quickstarts-showcase.
1 parent fafec33 commit 59e472f

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

runQuickstartsFromSource.bat

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
setLocal enableExtensions enableDelayedExpansion
33

44
cd build
5-
mvnw verify -DskipTests && ^
5+
mvnw -f .. verify -DskipTests && cd build && ^
66
mvnw -f quickstarts-showcase quarkus:dev -Dstartup-open-browser=true
77
cd ..
8+
cd ..

0 commit comments

Comments
 (0)