Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discourage f or x prefix on specs #63

Closed
SimenB opened this issue Feb 10, 2018 · 3 comments · Fixed by severest/retrobot#29
Closed

Discourage f or x prefix on specs #63

SimenB opened this issue Feb 10, 2018 · 3 comments · Fixed by severest/retrobot#29
Labels
good first issue help wanted new rule

Comments

@SimenB
Copy link
Member

SimenB commented Feb 10, 2018

Instead of doing fit, xit etc, one should do it.only and it.skip. Same for describe.

Should also be fixable
SimenB referenced this issue in macklinu/eslint-plugin-jest Feb 10, 2018
@macklinu
feat(wip): add always-test-or-it rule
76acf1f 
See jest-community#12
@ranyitz
Copy link
Contributor

ranyitz commented Feb 10, 2018

I can also take this issue as it closely related to #12

name suggestions:

  1. prefer-only-skip
  2. no-fx-prefix

@SimenB
Copy link
Member Author

SimenB commented Feb 10, 2018

I like the first one :) @thymikee?

@thymikee
Copy link
Member

@SimenB yup, I'm on your side on this :)

@ranyitz ranyitz mentioned this issue Feb 11, 2018
Merged
@SimenB SimenB closed this as completed in a12a2d2 Feb 12, 2018
This was referenced Feb 12, 2018
Merged
Merged
@dependabot-preview dependabot-preview bot mentioned this issue Mar 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted new rule
Projects
None yet
Milestone
No milestone
3 participants
@SimenB @thymikee @ranyitz