Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Walk #89

Open
jgm opened this issue Mar 12, 2021 · 2 comments
Open

Improve Walk #89

jgm opened this issue Mar 12, 2021 · 2 comments

Comments

@jgm
Copy link
Owner

jgm commented Mar 12, 2021

Walk is a bit of a mess. It seems we should be able to do something more elegant, using recursion schemes or something.

For motivation see jgm/pandoc#7130.
Here we have walk fixLinks where fixLinks is [Inline] -> [Inline].
It works fine if applied to [Inline]. However, it behaves differently if you apply it to Inlines. Seems like instead of having instances specifically for lists, we should have general instances that work for all Traversable/Foldable structures, including Many.
@ricnorr
Copy link

ricnorr commented Mar 26, 2022

Is it already fixed? I can't find any 'Inlines' in code.

@jgm
Copy link
Owner Author

jgm commented Mar 26, 2022

Inlines from T.P.Builder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jgm @ricnorr