Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce formatting in CI #148

Open
hannobraun opened this issue Dec 6, 2021 · 0 comments
Open

Enforce formatting in CI #148

hannobraun opened this issue Dec 6, 2021 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed status: blocked Can't be worked on right now

Comments

@hannobraun
Copy link
Contributor

#147 formats the code using cargo fmt, but doesn't update the CI build to enforce that. I think this should be done, as otherwise the formatting is going to drift again, over time.

When doing that, it might be worth deciding whether to include any formatting configuration that deviates from the default. Personally, I'm always changing the maximum line width to 80 characters (max_width = 80), as any other value is objectively too long or too short (no doubt about it 😁).

Blocked on #128.

@hannobraun hannobraun added help wanted Extra attention is needed good first issue Good for newcomers status: blocked Can't be worked on right now labels Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed status: blocked Can't be worked on right now
Projects
None yet
Development

No branches or pull requests

1 participant