Skip to content

Commit 52d8411

Browse files
committed
fix: allow to drop on items that cannot be dragged
1 parent 5468685 commit 52d8411

File tree

2 files changed

+22
-2
lines changed

2 files changed

+22
-2
lines changed

src/components/FinderItem.vue

+2-2
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ export default {
165165
this.treeModel.startDrag(this.node.id);
166166
},
167167
onDragOver(event) {
168-
if (!this.canDrag) {
168+
if (!this.dragEnabled) {
169169
return;
170170
}
171171
@@ -182,7 +182,7 @@ export default {
182182
this.ghost.parentNode.removeChild(this.ghost);
183183
this.ghost = null;
184184
}
185-
if (!this.canDrag) {
185+
if (!this.dragEnabled) {
186186
return;
187187
}
188188

src/components/__tests__/FinderItem.test.js

+20
Original file line numberDiff line numberDiff line change
@@ -445,6 +445,26 @@ describe("FinderItem", () => {
445445

446446
expect(dataTransfer.dropEffect).toBeUndefined();
447447
});
448+
449+
it("should set dataTransfer.dropEffect = `all` if `dragEnabled` is a function returning `false`", async () => {
450+
const dataTransfer = {};
451+
const wrapper = mount(FinderItem, {
452+
propsData: {
453+
treeModel,
454+
node,
455+
dragEnabled: () => false,
456+
options: {
457+
canDrop: () => true
458+
}
459+
}
460+
});
461+
462+
await wrapper.trigger("dragover", {
463+
dataTransfer
464+
});
465+
466+
expect(dataTransfer.dropEffect).toBe("move");
467+
});
448468
});
449469

450470
describe("dragend", () => {

0 commit comments

Comments
 (0)