Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 ScrollReveal function name bug? #191

Closed
paulogawa opened this issue Dec 2, 2015 · 1 comment
Closed

v3 ScrollReveal function name bug? #191

paulogawa opened this issue Dec 2, 2015 · 1 comment

Comments

@paulogawa
Copy link

In V2, you have your main ScrollReveal function camel-cased (scrollReveal) while in V3, you changed it so it's now ScrollReveal. This breaks the call to the function when going from v2 to v3 because Javascript is case sensitive.

Also in your ScrollReveal 3 PR documentation (#168), you left the call to the function camel-cased so it won't work.

window.sr = 
  new scrollReveal( defaults 
    .reveal( '.foo', myReveal )
    .reveal( '.bar', 'vFactor 0.2 and enter left' )
    .init();
@jlmakes
Copy link
Owner

jlmakes commented Dec 2, 2015

Thanks for trying 3.0 @pauliwago

"This breaks the call to the function when going from v2 to v3 because Javascript is case sensitive."

You are correct. ScrollReveal 3 is going to be a massive (and breaking) upgrade. The issue raised in #176 has prompted the change you’re talking about, and I’ve updated the PR documentation sample code. Good catch!

Sorry for the confusion, you’ve caught things mid-transition as I plan to launch very soon. If you’ll look, you’ll see even the demo site is down. Only a few more days before I tie the loose ends. 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants