You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In V2, you have your main ScrollReveal function camel-cased (scrollReveal) while in V3, you changed it so it's now ScrollReveal. This breaks the call to the function when going from v2 to v3 because Javascript is case sensitive.
Also in your ScrollReveal 3 PR documentation (#168), you left the call to the function camel-cased so it won't work.
window.sr=newscrollReveal(defaults.reveal('.foo',myReveal).reveal('.bar','vFactor 0.2 and enter left').init();
The text was updated successfully, but these errors were encountered:
"This breaks the call to the function when going from v2 to v3 because Javascript is case sensitive."
You are correct. ScrollReveal 3 is going to be a massive (and breaking) upgrade. The issue raised in #176 has prompted the change you’re talking about, and I’ve updated the PR documentation sample code. Good catch!
Sorry for the confusion, you’ve caught things mid-transition as I plan to launch very soon. If you’ll look, you’ll see even the demo site is down. Only a few more days before I tie the loose ends. 🙇
In V2, you have your main ScrollReveal function camel-cased (scrollReveal) while in V3, you changed it so it's now ScrollReveal. This breaks the call to the function when going from v2 to v3 because Javascript is case sensitive.
Also in your ScrollReveal 3 PR documentation (#168), you left the call to the function camel-cased so it won't work.
The text was updated successfully, but these errors were encountered: