Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CacheInfo Prefered #204

Closed
SuperQ opened this issue Nov 27, 2023 · 1 comment · Fixed by #224
Closed

Rename CacheInfo Prefered #204

SuperQ opened this issue Nov 27, 2023 · 1 comment · Fixed by #224

Comments

@SuperQ
Copy link
Contributor

SuperQ commented Nov 27, 2023

The CacheInfo struct in address.go has a misspelled variable, Prefered. This should be Preferred.

This is a breaking change, not sure how this should be handled here.
@jsimonetti
Copy link
Owner

I guess it depends on whether CacheInfo.Prefered is really used.
It is such a deep attribute, I doubt many people actually use it.

Otoh, to be safe, a major version upgrade would be required.

I'll see if I can get some info out of the github SBOM interface and check if any github hosted projects use that attribute.

@jsimonetti jsimonetti mentioned this issue May 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename CacheInfo Prefered jsimonetti/rtnetlink
2 participants
@SuperQ @jsimonetti