Skip to content

Commit 2477da6

Browse files
authored
Merge pull request #393 from afshin/default-url
Re-enable default_url in ExtensionApp
2 parents edf4a08 + 028feb0 commit 2477da6

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

jupyter_server/extension/application.py

+9-1
Original file line numberDiff line numberDiff line change
@@ -180,6 +180,12 @@ def get_extension_point(cls):
180180
# Extension URL sets the default landing page for this extension.
181181
extension_url = "/"
182182

183+
default_url = Unicode().tag(config=True)
184+
185+
@default('default_url')
186+
def _default_url(self):
187+
return self.extension_url
188+
183189
# Extension can configure the ServerApp from the command-line
184190
classes = [
185191
ServerApp,
@@ -332,7 +338,6 @@ def _jupyter_server_config(cls):
332338
base_config = {
333339
"ServerApp": {
334340
"jpserver_extensions": {cls.get_extension_package(): True},
335-
"default_url": cls.extension_url
336341
}
337342
}
338343
base_config["ServerApp"].update(cls.serverapp_config)
@@ -438,6 +443,9 @@ def _load_jupyter_server_extension(cls, serverapp):
438443
if cls._is_starter_app:
439444
serverapp._starter_app = extension
440445
extension.initialize()
446+
# Set the serverapp's default url to the extension's url.
447+
if cls._is_starter_app:
448+
serverapp.default_url = extension.default_url
441449
return extension
442450

443451
@classmethod

0 commit comments

Comments
 (0)