Skip to content

Commit 7956dc5

Browse files
decode bytes from secure cookie (#562)
The get_secure_cookie interface returns bytes not str https://www.tornadoweb.org/en/stable/web.html#tornado.web.RequestHandler.get_secure_cookie This fixes a minor issue where `handler.get_current_user` would return bytes rather than str.
1 parent 2d43c93 commit 7956dc5

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

jupyter_server/auth/login.py

+2
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,8 @@ def get_user(cls, handler):
172172
if user_id is None:
173173
get_secure_cookie_kwargs = handler.settings.get('get_secure_cookie_kwargs', {})
174174
user_id = handler.get_secure_cookie(handler.cookie_name, **get_secure_cookie_kwargs )
175+
if user_id:
176+
user_id = user_id.decode()
175177
else:
176178
cls.set_login_cookie(handler, user_id)
177179
# Record that the current request has been authenticated with a token.

0 commit comments

Comments
 (0)