Skip to content

Commit 87298c9

Browse files
committed
return True on successful ExtensionPoint validation
and include validate() in test coverage, which fails prior to the change because validate() returned None
1 parent 5e77b73 commit 87298c9

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

jupyter_server/extension/manager.py

+2
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,8 @@ def validate(self):
129129
self._get_loader()
130130
except Exception:
131131
return False
132+
else:
133+
return True
132134

133135
def link(self, serverapp):
134136
"""Link the extension to a Jupyter ServerApp object.

jupyter_server/tests/extension/test_manager.py

+2
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ def test_extension_point_api():
3030
assert app is not None
3131
assert callable(e.load)
3232
assert callable(e.link)
33+
assert e.validate()
3334

3435

3536
def test_extension_point_metadata_error():
@@ -59,6 +60,7 @@ def test_extension_package_api():
5960
assert hasattr(e, "extension_points")
6061
assert len(e.extension_points) == len(metadata_list)
6162
assert app.name in e.extension_points
63+
assert e.validate()
6264

6365

6466
def test_extension_package_notfound_error():

0 commit comments

Comments
 (0)