Skip to content

Commit 8de93c8

Browse files
Backport PR #1139 on branch 1.x (Raise errors on individual problematic extensions when listing extension) (#1141)
Co-authored-by: Zachary Sailer <[email protected]>
1 parent 28c9e29 commit 8de93c8

File tree

1 file changed

+14
-4
lines changed

1 file changed

+14
-4
lines changed

jupyter_server/extension/serverextension.py

+14-4
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
"""Utilities for installing extensions"""
22
# Copyright (c) Jupyter Development Team.
33
# Distributed under the terms of the Modified BSD License.
4+
import logging
45
import os
56
import sys
67

@@ -320,20 +321,29 @@ def list_server_extensions(self):
320321
)
321322

322323
for option in configurations:
323-
config_dir, ext_manager = _get_extmanager_for_context(**option)
324+
config_dir = _get_config_dir(**option)
324325
self.log.info(f"Config dir: {config_dir}")
325-
for name, extension in ext_manager.extensions.items():
326-
enabled = extension.enabled
326+
write_dir = "jupyter_server_config.d"
327+
config_manager = ExtensionConfigManager(
328+
read_config_path=[config_dir],
329+
write_config_dir=os.path.join(config_dir, write_dir),
330+
)
331+
jpserver_extensions = config_manager.get_jpserver_extensions()
332+
for name, enabled in jpserver_extensions.items():
327333
# Attempt to get extension metadata
328334
self.log.info(f" {name} {GREEN_ENABLED if enabled else RED_DISABLED}")
329335
try:
330336
self.log.info(f" - Validating {name}...")
337+
extension = ExtensionPackage(name=name, enabled=enabled)
331338
if not extension.validate():
332339
raise ValueError("validation failed")
333340
version = extension.version
334341
self.log.info(f" {name} {version} {GREEN_OK}")
335342
except Exception as err:
336-
self.log.warning(f" {RED_X} {err}")
343+
exc_info = False
344+
if int(self.log_level) <= logging.DEBUG:
345+
exc_info = True
346+
self.log.warning(f" {RED_X} {err}", exc_info=exc_info)
337347
# Add a blank line between paths.
338348
self.log.info("")
339349

0 commit comments

Comments
 (0)