Skip to content

Commit 903942c

Browse files
authored
Fix ci failures (#1222)
1 parent 2b42b90 commit 903942c

File tree

2 files changed

+18
-7
lines changed

2 files changed

+18
-7
lines changed

.github/workflows/integration-tests.yml

+15-7
Original file line numberDiff line numberDiff line change
@@ -11,24 +11,32 @@ jobs:
1111
fail-fast: false
1212
matrix:
1313
os: [ubuntu-latest]
14-
python-version: ["3.8", "3.9", "3.10", "3.11", "pypy-3.8"]
14+
python-version: ["3.8", "3.9", "3.10", "3.11"]
1515
steps:
16-
- name: Checkout
17-
uses: actions/checkout@v3
18-
- name: Base Setup
19-
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
16+
- uses: actions/checkout@v3
17+
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
2018
- name: Run the tests
21-
run: |
22-
hatch run cov:integration
19+
run: hatch run cov:integration
2320
- name: Coverage
2421
run: |
2522
pip install codecov coverage[toml]
2623
codecov
2724
25+
build_pypy:
26+
runs-on: ubuntu-latest
27+
steps:
28+
- uses: actions/checkout@v3
29+
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
30+
with:
31+
python_version: "pypy-3.8"
32+
- name: Run the tests
33+
run: hatch run test:nowarn --integration_tests=true
34+
2835
integration_check: # This job does nothing and is only used for the branch protection
2936
if: always()
3037
needs:
3138
- build
39+
- build_pypy
3240
runs-on: ubuntu-latest
3341
steps:
3442
- name: Decide whether the needed jobs succeeded or failed

tests/services/contents/test_manager.py

+3
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,9 @@ def test_get_os_path(jp_file_contents_manager_class, tmp_path):
163163
fs_path = os.path.join(fm.root_dir, "test.ipynb")
164164
assert path == fs_path
165165

166+
167+
@pytest.mark.skipif(os.name == "nt", reason="Posix only")
168+
def test_get_os_path_posix(jp_file_contents_manager_class, tmp_path):
166169
fm = jp_file_contents_manager_class(root_dir=str(tmp_path))
167170
path = fm._get_os_path("////test.ipynb")
168171
fs_path = os.path.join(fm.root_dir, "test.ipynb")

0 commit comments

Comments
 (0)