Fix nbconvert handler run_sync()

Author: davidbrochart

jupyter_server/nbconvert/handlers.py

@@ -40,7 +40,9 @@ def respond_zip(handler, name, output, resources):
     zip_filename = os.path.splitext(name)[0] + ".zip"
     handler.set_attachment_header(zip_filename)
     handler.set_header("Content-Type", "application/zip")
-    handler.set_header("Cache-Control", "no-store, no-cache, must-revalidate, max-age=0")
+    handler.set_header(
+        "Cache-Control", "no-store, no-cache, must-revalidate, max-age=0"
+    )
 
     # Prepare the zip file
     buffer = io.BytesIO()
@@ -119,7 +121,7 @@ async def get(self, format, path):
         # Exporting can take a while, delegate to a thread so we don't block the event loop
         try:
             output, resources = await run_sync(
-                exporter.from_notebook_node(nb, resources=resource_dict)
+                exporter.from_notebook_node, nb, resource_dict
             )
         except Exception as e:
             self.log.exception("nbconvert failed: %s", e)
@@ -135,9 +137,13 @@ async def get(self, format, path):
 
         # MIME type
         if exporter.output_mimetype:
-            self.set_header("Content-Type", "%s; charset=utf-8" % exporter.output_mimetype)
+            self.set_header(
+                "Content-Type", "%s; charset=utf-8" % exporter.output_mimetype
+            )
 
-        self.set_header("Cache-Control", "no-store, no-cache, must-revalidate, max-age=0")
+        self.set_header(
+            "Cache-Control", "no-store, no-cache, must-revalidate, max-age=0"
+        )
         self.finish(output)
 
 
@@ -146,20 +152,19 @@ class NbconvertPostHandler(JupyterHandler):
     SUPPORTED_METHODS = ("POST",)
 
     @web.authenticated
-    def post(self, format):
+    async def post(self, format):
         exporter = get_exporter(format, config=self.config)
 
         model = self.get_json_body()
         name = model.get("name", "notebook.ipynb")
         nbnode = from_dict(model["content"])
 
         try:
-            output, resources = exporter.from_notebook_node(
+            output, resources = await run_sync(
+                exporter.from_notebook_node,
                 nbnode,
-                resources={
-                    "metadata": {
-                        "name": name[: name.rfind(".")],
-                    },
+                {
+                    "metadata": {"name": name[: name.rfind(".")]},
                     "config_dir": self.application.settings["config_dir"],
                 },
             )
@@ -171,7 +176,9 @@ def post(self, format):
 
         # MIME type
         if exporter.output_mimetype:
-            self.set_header("Content-Type", "%s; charset=utf-8" % exporter.output_mimetype)
+            self.set_header(
+                "Content-Type", "%s; charset=utf-8" % exporter.output_mimetype
+            )
 
         self.finish(output)