Skip to content

Commit f8e122b

Browse files
authored
Backport #981: Make it easier to pass custom env variables to kernel (#994)
1 parent 507c697 commit f8e122b

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

jupyter_server/services/sessions/sessionmanager.py

+7-2
Original file line numberDiff line numberDiff line change
@@ -268,14 +268,19 @@ async def create_session(
268268
self._pending_sessions.remove(record)
269269
return result
270270

271+
def get_kernel_env(self, path):
272+
"""Return the environment variables that need to be set in the kernel"""
273+
return {**os.environ, "JPY_SESSION_NAME": path}
274+
271275
async def start_kernel_for_session(self, session_id, path, name, type, kernel_name):
272276
"""Start a new kernel for a given session."""
273277
# allow contents manager to specify kernels cwd
274-
kernel_path = self.contents_manager.get_kernel_path(path=path)
278+
kernel_path = await ensure_async(self.contents_manager.get_kernel_path(path=path))
279+
kernel_env = self.get_kernel_env(path)
275280
kernel_id = await self.kernel_manager.start_kernel(
276281
path=kernel_path,
277282
kernel_name=kernel_name,
278-
env={**os.environ, "JPY_SESSION_NAME": path},
283+
env=kernel_env,
279284
)
280285
return kernel_id
281286

0 commit comments

Comments
 (0)