Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Content-Type header set for SVG files when served from Gateway #1216

Open
mbektas opened this issue Feb 18, 2023 · 0 comments
Open

Incorrect Content-Type header set for SVG files when served from Gateway #1216

mbektas opened this issue Feb 18, 2023 · 0 comments
Labels
bug

Comments

@mbektas
Copy link
Contributor

mbektas commented Feb 18, 2023 •
edited
Loading

Description

When kernelspecs API returns SVG icons via gateway, the Content-Type set by GatewayResourceHandler is overridden as application/json. This causes browser to fail rendering the icon properly. JupyterLab prefers SVG kernel icons since this commit.
kernelspec svg icon issue

Reproduce

  1. Launch JupyterLab with --GatewayClient.url arg
  2. Open Launcher in JupyterLab

Expected behavior

Correct Content-Type header should be set and icon should render properly

Context

  • Operating System and version: macOS
  • Browser and version: Chrome
  • Jupyter Server version: 1.x, 2.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix Content-Type header set for SVG files mbektas/jupyter_server
1 participant
@mbektas