Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an integration test using IRKernel #642

Open
blink1073 opened this issue Dec 16, 2021 · 1 comment
Open

Add an integration test using IRKernel #642

blink1073 opened this issue Dec 16, 2021 · 1 comment

Comments

@blink1073
Copy link
Contributor

Problem

We are currently only testing against ipykernel. If we were testing against at least one other kernel we can help prevent issues like #633.

Proposed Solution

Add a CI job that installs IRKernel in a conda environment and runs a test that starts the server, a kernel, and executes on the kernel.

Additional context

Use jupyter_kernel_test as an example for the CI setup.

@bollwyvl
Copy link
Contributor

from our experiences on jupyter-lsp, conda solves with r-*+jupyter_* can be... expensive. even with mamba(forge). but especially on windows. but worth it, because there are a lot of windows r users.

it may be worth considering pre-solving and caching the solutions in ci with conda-lock... there's some skullduggery it does where this could be done in an up-front job with a cheap pip installed conda-lock, do the solves for all the platforms, and kick those down to jobs for the big three OSes.

also: it's rad someone's been working on jupyter_kernel_test ❤️‍🔥 !

@jess-x jess-x self-assigned this Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants